tpetra: return packed indices always in getNodePackedIndices #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dices changing getNodeRowPtrs and getAllValues to do the packed analogues
7 tasks
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_intel_17.0.1 to start: Total Wait = 603
|
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
brian-kelley
approved these changes
Nov 1, 2021
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Nov 2, 2021
…s:develop' (5d85ab5). * trilinos-develop: tpetra: trilinos#9884 changing getNodePackedIndices to truly return packed indices (trilinos#9885)
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Nov 3, 2021
…s:develop' (5d85ab5). * trilinos-develop: Fix bug with mkl spgemm tpetra: trilinos#9884 changing getNodePackedIndices to truly return packed indices (trilinos#9885)
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Nov 4, 2021
…s:develop' (5d85ab5). * trilinos-develop: Fix bug with mkl spgemm tpetra: trilinos#9884 changing getNodePackedIndices to truly return packed indices (trilinos#9885)
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Nov 4, 2021
…s:develop' (5d85ab5). * trilinos-develop: Fix bug with mkl spgemm tpetra: trilinos#9884 changing getNodePackedIndices to truly return packed indices (trilinos#9885)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra
Motivation
As we removed UVM dependence from Tpetra, we saw that CrsGraph::getNodePackedIndices returned k_lclInds1D_, which was packed iff fillComplete was called with storageOptimized. Thus, if not storageOptimized, this function might return unpacked indices. However, unpacked indices aren't useful without the number of entries in each row, so the function's intent (indicated by its name) was more appropriate.
In the first round of UVM removal, we kept the existing behavior by returning views of the unpacked indices.
Now, with this PR, we change the behavior of CrsGraph's getNodePackedIndices and getNodeRowPtrs, and CrsMatrix's getAllValues (which uses the CrsGraph functions) to truly return packed indices, row pointers, and values, respectively, in all use cases.
Stakeholder Feedback
Testing
Tested on ascicgpu030 with sems modules and Serial node, and with sierra nvidia modules and CUDA node, no UVM.