Complete implementation of install hooks as byproduct of ctest -S drivers #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit f4cf3b519640475496117fc084fe92b7fcbbde70 Author: Roscoe A. Bartlett <[email protected]> Date: Tue Jan 22 12:49:57 2019 -0700 Summary: cdash_build_testing_date.py tool and unit tests (trilinos#2689)
See the updated documentation for details. Should be pretty clear from that.
bartlettroscoe
added
type: enhancement
|
@fryeguy52, can you please take a quick look at the documentation here and here and then approve the PR? I want to get this merged before tonight so that the Trilinos installs will run tonight and tomorrow. If you see any changes that should be made, please note them in this PR and then we can create a new PR that addresses them. Since this PR touches files that will trigger a build of all Trilinos packages (because it contains an update of TriBITS), I don't want to have to do another round of PR testing it it will never get done today. |
bartlettroscoe
added
the
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
bartlettroscoe
commented
Jan 24, 2019
|
|
||
| This tool is meant to match the CDash logic for what testing day a given CDash | ||
| build matches for the CDash 'date' field in various PHP pages for a given | ||
| CDash build with a give build start time (as reported to CDash from CTest). |
There was a problem hiding this comment.
change to "with a given build start time".
mhoemmen
approved these changes
Jan 25, 2019
|
Thanks @mhoemmen! |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 4261: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @fryeguy52
Description
This adds functionality to install Trilinos as a byproduct in of running ctest -S scripts.
Please see the new documentation here and here.
Motivation and Context
This is needed to allow the testing of SPARC 'master' against Trilinos 'develop' (see TRIL-243).
How Has This Been Tested?
I tested this locally. See TRIL-243 for detailed testing against SPARC 'master'.
Checklist