Development and cleanup #313
Conversation
Adds sprite based icons, added some accessibility support since this uses background images. Can use classes `left` or `right` on parent div to align on either side of SSID, parent div `invert` css filters the icons to white. base64 image string has been formatted for easy replacement
adds template and layer png master
abstracted ap password validation passing a invalid password should be fatal , not fallback to null, but could be an optional define
WiFiManager.cpp
Outdated
| if (_apPassword != NULL) { | ||
| WiFi.softAP(_apName, _apPassword);//password option | ||
| } else { | ||
| WiFi.softAP(_apName); | ||
| } | ||
|
|
||
| delay(500); // Without delay I've seen the IP address blank | ||
| delay(500); // slight delay to make sure we have a password |
There was a problem hiding this comment.
I meant ip address doh
|
hate it when github updates the site when I am using it, heh looks all different now. |
* broke large functions into smaller , to allow new features to be hooked in easier * added persistent test to constructor destructor * testing turn off sta during portal , causes issues
This might need better handling in future, since we only get back a bool of wether or not we are connected, not if configportal was saved etc. might be a problem.
This was actually being called before the ap was setup!
|
I am currently trying to figure out this one resilient problem, when the configportal save fails, and the portal is closed or timesout, somehow, persistent mode is being set to AP or AP_STA which ever we are using, and i cannot for the life of me get it to turn off, ever using custom code that should. I have opened an issue with arduino sdk and are looking into the SDK bugs to see if this is a known issue fixed in 2.0, ill test master soon. basically softap disconnect fails to save config to flash it seems. Even though I am in AP mode as per the SDK, there seems to be some bug here, still narrowing it down . |
|
maybe the not saving issue could be caused by some combination of the persistent flags and switching modes? wouldn't be the weirdest thing i ve seen it do... |
|
I spend all weekend on this and have it figured out. Ill detail it later, I also might have a fix. |
Fix broken link
Spelling fixes thanks
This seems like a simple typo to me
uninitialized abort caused immediate exit
this is getting rediculous, dev on 2_3_0 has to stop there are so many bugs.
pass stream reference via constructor to use for _debugPort in DEBUG_WM, if someone needs dynamic we can add pointer setter, but seems overkill
disocnnect STA on save failures move reset out of configportal loop
adds connect info to root info and wifi, minimal wordyness
|
@tzapu can I merge and continue work on this ? |
|
please do, you are the lead my man thank you |
cleaning up a bit, better comments, some questions
@todo, improved some debug messages.abstracted appassword check, and made fatal, not fallback to anonymous.