Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw data regression tests to expect JSON text sequences. #381

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

aaronweeden
Copy link
Contributor

@aaronweeden aaronweeden commented May 30, 2024

Description

This PR updates the raw data regression tests to expect JSON text sequences. This synchronizes with the changes from ubccr/xdmod#1858.

Tests performed

In a Docker container running tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1, I cloned copies of this branch and the branch from ubccr/xdmod#1861, manually followed the upgrade steps for CircleCI, and confirmed the regression tests all pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronweeden aaronweeden added the qa label May 30, 2024
@aaronweeden aaronweeden added this to the 11.0.0 milestone May 30, 2024
@aaronweeden aaronweeden marked this pull request as ready for review May 31, 2024 18:07
@ryanrath ryanrath self-requested a review June 7, 2024 16:04
@aaronweeden aaronweeden merged commit 19d9a33 into ubccr:xdmod11.0 Jun 7, 2024
3 checks passed
@aaronweeden aaronweeden deleted the update-regression-tests branch June 7, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants