Fix sorting in regression tests of raw data. #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
aaronweeden
force-pushed
the
fix-raw-data-sorting
branch
from
a7ae711
to
228639c
Compare
eiffel777
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the regression tests of the
/warehouse/raw-dataendpoint such that, if thesortoption istrue, the last newline character of the sorted response text stays at the end rather than being moved to the beginning.Motivation and Context
This makes it easier to view and debug the expected test artifacts and actual responses for the tests in question. In addition, ubccr/xdmod-supremm#381 depends on this PR.
Tests performed
In a Docker container running
tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1, I cloned copies of this branch and the branch from ubccr/xdmod-supremm#381, manually followed theupgradesteps for CircleCI, and confirmed the regression tests all pass.Checklist: