Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify xdmod source for php7 compatibility #101

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

jsperhac
Copy link
Contributor

@jsperhac jsperhac commented Apr 20, 2017

Description

Fixed up xdmod core source based on the output of php7cc version compatibility checker (https:/sstalle/php7cc). This provided an opportunity to delete some woefully dated source code that used deprecated syntax and packages.

This is necessarily a mixed bag of changes, consisting of code deletions, class renaming, deletion of unused database tables, and adjustment of syntax in the test harness.

Refer to pull requests https:/ubccr/xdmod-xsede/pull/29 and ubccr/xdmod-appkernels#18 for associated changes for php7 compatibility

As spelled out in the original commit remarks:

  • Renamed the open XDMoD shredded ingestor Resource class, and fixed call to class (reserved word)
  • Replaced split() with explode() in XdmodTestHelper
  • Removed unused class Glossary.php and unused moddb tables Glossary and GlossaryAliases
  • Removed unused source controllers/ui_data/repogen_sites.php
  • Removed unused source libraries/network.php
  • Removed unused tokenResolver() from libraries/utilities.php
  • Removed old, unused controller code associated with user_profile

Motivation and Context

This PR helps prepare xdmod for a migration to a newer PHP version, and provides the opportunity to prune some unused and outdated code.

Tests performed

All existing integration and unit tests were run without incident. Where coverage is limited (e.g. user profile), manual testing was done to ensure no behavioral changes were introduced.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -0,0 +1,3 @@
DROP TABLE IF EXISTS `Glossary`;

DROP TABLE IF EXISTS `GlossaryAliases`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to the bottom of the file:

INSERT INTO `schema_version_history` VALUES ('moddb', '6.7.0', NOW(), 'upgraded', 'N/A');

Also, please update the schema version in db/data/moddb.sql.

The schema versions aren't used for anything at this time, but might as well keep updating them until we decide if we want to get rid of them.

@jsperhac jsperhac merged commit 678b7c7 into ubccr:xdmod6.7 Apr 20, 2017
@jsperhac jsperhac deleted the php7-xdmod branch April 20, 2017 20:13
tyearke added a commit that referenced this pull request May 5, 2017
@tyearke tyearke added enhancement Enhancement of the functionality of an existing feature qa labels May 10, 2017
@tyearke tyearke added this to the v6.7.0 milestone May 10, 2017
@tyearke tyearke modified the milestones: v7.0.0, v6.7.0 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants