Bumped build_packager script memory limit #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When executing a local deploy ( as opposed to pulling down the source from a git repo ) this script consistently runs out of memory. Bumping the limit to 256M alleviates this issue.
jtpalmer
suggested changes
Apr 28, 2017
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| require_once __DIR__ . '/../../configuration/linker.php'; | |||
|
|
|||
| ini_set('memory_limit', '256M'); | |||
There was a problem hiding this comment.
I would prefer that the memory limit be disabled as is done in the other scripts. e.g. https:/ubccr/xdmod/blob/xdmod6.6/bin/xdmod-upgrade#L20
- Updated per code review comment by @jtpalmer
jtpalmer
approved these changes
Apr 28, 2017
jtpalmer
pushed a commit
to jtpalmer/xdmod
that referenced
this pull request
May 11, 2017
* Bumped build_packager memory limit - When executing a local deploy ( as opposed to pulling down the source from a git repo ) this script consistently runs out of memory. Bumping the limit to 256M alleviates this issue. * Removed Memory Limit for build_package.php script - Updated per code review comment by @jtpalmer
chakrabortyr
pushed a commit
to chakrabortyr/xdmod
that referenced
this pull request
Oct 17, 2017
* Bumped build_packager memory limit - When executing a local deploy ( as opposed to pulling down the source from a git repo ) this script consistently runs out of memory. Bumping the limit to 256M alleviates this issue. * Removed Memory Limit for build_package.php script - Updated per code review comment by @jtpalmer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
git repo ) this script consistently runs out of memory. Bumping the limit to
256M alleviates this issue.
Motivation and Context
The script was running out of memory, now it does not.
Tests performed
Types of changes
Checklist: