Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong And Weak Reference Issue (MemoryLeak) #83

Closed
farshadmb opened this issue Jun 24, 2017 · 10 comments
Closed

Strong And Weak Reference Issue (MemoryLeak) #83

farshadmb opened this issue Jun 24, 2017 · 10 comments
Labels

Comments

@farshadmb
Copy link
Contributor

@msaps Hi man
Here I am again 😊 😁
I found another issue that is critical in my opinion. The "Tabman" or "Pageboy", I do not know exactly. However, you use some strong reference cause appear this issue.

For Simulate what happened to me. Please Use NavigationController as application rootViewController then push object which inherits from "Tabman" library.
After that back to rootViewController of NavigationController. The "Tabman" or "Pageboy" must be deallocated after pop TabmanViewController or PageboyViewController but never called deinit
Note: declare deinit function in "Tabman" or "Pageboy" or A class inherit from both
deinit{ print("\(self)")
print self for debug log of the memory address.

@farshadmb farshadmb changed the title Strong And Weak Reference Issue Strong And Weak Reference Issue (MemoryLeak) Jun 24, 2017
@msaps
Copy link
Member

msaps commented Jun 24, 2017

@farshadmb I'll have a look and see if I can pinpoint which component the memory leak is occurring in. Agree it's a pretty critical issue!

@farshadmb
Copy link
Contributor Author

@msaps I can provide the sample project and I will send to your mail

@msaps
Copy link
Member

msaps commented Jun 24, 2017

@farshadmb okay cheers! Probably easier to upload as an attachment on this please. Emails are easier to lose! 😄

@farshadmb
Copy link
Contributor Author

@msaps here we go
I attached here
Download

@farshadmb
Copy link
Contributor Author

farshadmb commented Jun 24, 2017

@msaps I fixed memory leak issue 😊 #84

msaps added a commit that referenced this issue Jun 25, 2017
Fixed Memory leaking issue #83
@msaps
Copy link
Member

msaps commented Jun 25, 2017

@farshadmb thanks!! 👍

Merged, and I'll get it in 1.3.2 😄

@farshadmb
Copy link
Contributor Author

farshadmb commented Jun 25, 2017

@msaps your welcome dude
it seems we would be a great team 😊
so you can close this issue

@msaps
Copy link
Member

msaps commented Jun 25, 2017

Fixed as of 1.3.2.

@msaps msaps closed this as completed Jun 25, 2017
@msaps
Copy link
Member

msaps commented Jun 25, 2017

@farshadmb really appreciate all the work! 👍

@farshadmb
Copy link
Contributor Author

farshadmb commented Jun 25, 2017

@msaps now we can go to Tabman library and support library for iOS 8 and fix some bugs which I found on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants