Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Memory leaking issue #83 #84

Merged
merged 2 commits into from
Jun 25, 2017
Merged

Fixed Memory leaking issue #83 #84

merged 2 commits into from
Jun 25, 2017

Conversation

farshadmb
Copy link
Contributor

Hi Dear
@msaps I found the leaking object which holds pageboyViewController and doesn't allow to deallocate pageboyViewController after pop or dismiss

  • Fixed strong reference in CADisplayLink
  • Clear viewControllers content after deallocated
  • Fixed animation property strong reference

issue reference : MemoryLeak

- clear viewControllers content
- Fixed animation property strong reference
@msaps msaps changed the base branch from master to develop June 25, 2017 10:29
@codecov
Copy link

codecov bot commented Jun 25, 2017

Codecov Report

Merging #84 into develop will decrease coverage by 1.72%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
- Coverage    69.26%   67.54%   -1.73%     
===========================================
  Files           20       20              
  Lines         1012     1026      +14     
===========================================
- Hits           701      693       -8     
- Misses         311      333      +22
Impacted Files Coverage Δ
...tensions/PageboyViewController+Transitioning.swift 10.44% <0%> (-13.29%) ⬇️
...ources/Pageboy/Utilities/TransitionOperation.swift 0% <0%> (ø) ⬆️
Sources/Pageboy/PageboyViewController.swift 74.24% <0%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f933d0c...d08d01b. Read the comment docs.

@farshadmb
Copy link
Contributor Author

@msaps What was that 👍 🙃

@msaps
Copy link
Member

msaps commented Jun 25, 2017

@farshadmb just changed the base branch to develop and updated with the latest changes 😄

@msaps msaps merged commit fec890e into uias:develop Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants