Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor icav2-event-translator to bclconvert manager #303

Closed
wants to merge 1 commit into from
Closed

Refactor icav2-event-translator to bclconvert manager #303

wants to merge 1 commit into from

Conversation

alexiswl
Copy link
Member

  • icav2 event translator / now bclconvert manager
  • Move workflowrunstatechange into its own construct
  • TypeHint workflow run state change object, need to do a bit more testing on this first
  • Add samplesheet outputs and run info collection into icav2 copy command

@alexiswl
Refactor icav2-event-translator to bclconvert manager
e4da8b9 
* icav2 event translator / now bclconvert manager
* Move workflowrunstatechange into its own construct
* TypeHint workflow run state change object, need to do a bit more testing on this first
* Add samplesheet outputs and run info collection into icav2 copy command
@victorskl
Copy link
Member

victorskl commented May 17, 2024 •
edited
Loading

@alexiswl @raylrui are you two pair-programming working on this together? If so, that's ok.

Ray has #300 for on going PR #299 - just heads up, not to step on each other toe. If appropriate, pls pair programming together. I leave with you two.

@raylrui
Copy link
Contributor

raylrui commented May 17, 2024

Ray has #300 PR on going for #299 PR - just heads up, not to step on each other toe. If appropriate, pls pair programming together. I leave with you two.

not pair-programming, but I can see what Alexis want to build is a layer for the schema code binding, I will try to incorporate this idea in my #299 PR

@victorskl
Copy link
Member

Okay.

Alexis, heads up; schema code binding package is auto-generated one. Happy for any arrangement you guys want to establish here. Though, I'd advice please run past checking with Ray over zoom call to for this part; would be good.

@alexiswl
Copy link
Member Author

alexiswl commented May 17, 2024 •
edited
Loading

Yes, didn't realise that it was autogenerated, makes a lot of sense. Happy for ray to pull apart my PR as needed.

Aim is to get the samplesheet and run id as part of the output events for the bclconvert manager.

But I'd also like to use the WorkflowRunStateChange schema that's been generated for my services.

@alexiswl alexiswl mentioned this pull request May 22, 2024
Merged
@raylrui
Copy link
Contributor

raylrui commented May 29, 2024

Hi @alexiswl, suggest to close this one, as these feature have been included in #299

@victorskl
Copy link
Member

Closing as superseded by #299

@victorskl victorskl closed this May 29, 2024
@victorskl victorskl linked an issue May 29, 2024 that may be closed by this pull request
Update translator service to bclconvert manager #300
Closed
@raylrui raylrui deleted the refactor/update-icav2-enter-translator branch June 13, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update translator service to bclconvert manager
3 participants
@alexiswl @victorskl @raylrui