Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data schema registry and data schema deployment stack #320

Merged
merged 1 commit into from
May 24, 2024

Conversation

victorskl
Copy link
Member

  • Updated corresponding README and guide

Resolves #257

* Updated corresponding README and guide

Resolves #257
@alexiswl
Copy link
Member

Can we resolve #301 first?

See #303 as well

@alexiswl
Copy link
Member

Saves needing to migrate schemas in a few days' time

@victorskl
Copy link
Member Author

Yup, good idea. Let us regroup and resolve those one by one, today.

@victorskl
Copy link
Member Author

As discussed for #301, #303 - Ray will resolve with #299. When 299 ready, we shall review Ray's PR over there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted; any artefact under docs/schemas/data/ is under the full ownership (as well as a contract declaration; two-way bonds) of workflow execution services.

These particular contents adhere in this PR are just as examples for starter.

Please feel free to discard, improve, modify, rename as appropriate by the service owner see-fit.

FYI @raylrui @alexiswl

@victorskl
Copy link
Member Author

If you could review sooner and tick approve (or comment if any) - would be good. Then I will merge and follow up to change them JSON Schema.

Copy link
Contributor

@raylrui raylrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorskl victorskl merged commit 392ffd9 into main May 24, 2024
5 checks passed
@victorskl victorskl deleted the implement-data-schema branch May 24, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and finalise event schema
4 participants