chmod: supress verbose output when not verbose #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Comment on lines
193
to
+204
| if !self.quiet { | ||
| show!(USimpleError::new( | ||
| 1, | ||
| format!("cannot operate on dangling symlink {}", filename.quote()), | ||
| )); | ||
| } | ||
| if self.verbose { | ||
| println!( | ||
| "failed to change mode of {} from 0000 (---------) to 1500 (r-x-----T)", | ||
| filename.quote() | ||
| ); | ||
| } |
There was a problem hiding this comment.
Not your fault, but it's weird that quiet and verbose are separate booleans isn't it? Those options should override each other, so that
chmod --verbose --quiet
is the same as
chmod --quiet
And it's also not currently possible to do, for example,
chmod --verbose --verbose
Maybe this is a good opportunity to fix that?
There was a problem hiding this comment.
Well, nevermind, that's not how GNU chmod works! --verbose --quiet and --quiet are different in GNU so what you got is correct.
|
Thanks! If you're up for it, you can fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4381. Shows verbose output only when
--verboseflag is used instead