checksum: rework for improving checkum checking GNU behavior match #6654
+1,831
−1,055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm aware that this PR is consequent and that the rewrite is complex and difficult to review. That's why I tried to make meaningful commits so its easier to go step by step. I'm also considering to split this PR into several smaller ones, but I'm not sure where to split. |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
50c7ca5
to
a9a3706
Compare
RenjiSann
force-pushed
the
cksum-rework-bis
branch
2 times, most recently
from
8a191be
to
1d56096
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
1d56096
to
95b6cb1
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Aug 29, 2024
sylvestre
reviewed
Aug 29, 2024
| length: Option<usize>, | ||
| } | ||
|
|
||
| impl ChecksumAlgoBuilder { |
There was a problem hiding this comment.
please add a rustdoc comment here
RenjiSann
force-pushed
the
cksum-rework-bis
branch
4 times, most recently
from
63362c5
to
86fe708
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
86fe708
to
493280e
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
493280e
to
a5e11b4
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
2 times, most recently
from
1d6dbc4
to
0c8729d
Compare
|
I've finally managed to fix #6572, which needed a consequent rewrite of the logic. But hey, at least it works :) |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
0c8729d
to
b4b5252
Compare
|
changes: lint fixes + windows code error (as usual :') |
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
b4b5252
to
032ab96
Compare
sylvestre
force-pushed
the
cksum-rework-bis
branch
from
032ab96
to
3e2f330
Compare
|
it is still marked as draft, is it ready to be reviewed? |
sylvestre
force-pushed
the
cksum-rework-bis
branch
from
3e2f330
to
10e4ba8
Compare
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
cksum-rework-bis
branch
from
10e4ba8
to
744774e
Compare
test(cksum): add test for blake length gessing test(cksum): add test for hexa/base64 confusion test(cksum): add test for error handling on incorrectly formatted checksum test(cksum): add test for trailing spaces making a line improperly formatted test(cksum): Re-implement GNU test 'cksum-base64' in the testsuite
RenjiSann
force-pushed
the
cksum-rework-bis
branch
from
744774e
to
f5f6d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a significant refactor of the checksum checking code.
The current architecture prevents us to fix #6572, #6614 and #6653.
For #6614, we will need to implement a "retry" step in case we matched the hexa regex and we wish to try again considering the checksum as base64.
The refactor mainly consists in decomposing and extracting functionalities, and improving error management.
It adds several tests, for #6653 and #6572.
Its merge is gated by #6603, as it depends on its commits.