Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make socket listener tests more readable. #1027

Merged
merged 9 commits into from
Feb 25, 2024
Merged

Make socket listener tests more readable. #1027

merged 9 commits into from
Feb 25, 2024

Commits on Feb 25, 2024

  1. Move socket reading into response assert. 

    This removes reading from socket before asserting on the read value from multiple tests.
    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    56c8fb5 View commit details
    Browse the repository at this point in the history

  2. Add helper function to assert on values.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    85fad95 View commit details
    Browse the repository at this point in the history

  3. Remove unused cursor argument.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    86632bd View commit details
    Browse the repository at this point in the history

  4. Move repeating read logic to function.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    e51bfff View commit details
    Browse the repository at this point in the history

  5. Increase setup legibility. 

    2-3 booleans in a row are hard to read without confusion. Using enums instead.
    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    46a8a98 View commit details
    Browse the repository at this point in the history

  6. Move repeated writing logic to write helpers.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    94d2548 View commit details
    Browse the repository at this point in the history

  7. Add pointer to value helper function.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f336f97 View commit details
    Browse the repository at this point in the history

  8. Add another writer helper method.

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    5603351 View commit details
    Browse the repository at this point in the history

  9. fix comments

    @nihohit
    nihohit committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    8f1b87b View commit details
    Browse the repository at this point in the history