-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add SORT
and SORT_RO
commands
#1611
Merged
Yury-Fridlyand
merged 9 commits into
valkey-io:main
from
Bit-Quill:java/integ_guiang_sort
Jun 22, 2024
Merged
Java: Add SORT
and SORT_RO
commands
#1611
Yury-Fridlyand
merged 9 commits into
valkey-io:main
from
Bit-Quill:java/integ_guiang_sort
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename sortoptions and rebase.
java/client/src/main/java/glide/api/models/commands/SortBaseOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortStandaloneOptions.java
Outdated
Show resolved
Hide resolved
Please resolve conflicts and update PR description to reflect new names |
GumpacG
force-pushed
the
java/integ_guiang_sort
branch
from
June 20, 2024 19:06
6ad90c1
to
6d1c158
Compare
acarbonetto
reviewed
Jun 20, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericClusterCommands.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortBaseOptions.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortBaseOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/SortOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/ClusterTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/ClusterTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR description - one more time
Updated the PR description, thanks! |
acarbonetto
reviewed
Jun 21, 2024
java/client/src/test/java/glide/api/RedisClusterClientTest.java
Outdated
Show resolved
Hide resolved
* Added test * Added child classes * Needs cleaning up and store needs separate functions * Simplified sort apis * Separated sortOptions and sortStandAloneOptions * Added tests * Added IT and UT * Revert to Builder from SuperBuilder * Added javadocs * Added transaction tests * Addressed comments * Spotless * Added SortBaseOptions * Addressed docs comments * Fixed comment * Refactor sortWithStore to sortStore * Addressed comments * Update java/client/src/main/java/glide/api/commands/GenericBaseCommands.java Co-authored-by: Yury-Fridlyand <[email protected]> --------- Co-authored-by: Yury-Fridlyand <[email protected]>
…java Co-authored-by: Yury-Fridlyand <[email protected]>
GumpacG
force-pushed
the
java/integ_guiang_sort
branch
from
June 21, 2024 22:33
b3e5b24
to
b15aec8
Compare
acarbonetto
approved these changes
Jun 21, 2024
Elen-Ghulam
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/sort/
https://redis.io/docs/latest/commands/sort_ro/
**Description
Dependent on #1528
According to #1439 (comment) and Python implementation for SORT and SORT_RO, BY and GET are only supported in standalone client. Then STORE required it’s own function as it has a different return type.
StandaloneOptions adds
BY
andGET
options to the command. SortOptions addsLIMIT
,GET
,ASC
,DESC
,LIMIT
, andSTORE
.APIs supported in standalone client:
APIs supported in cluster client:
Note: Javadocs are based off of #1439 and #1528.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.