Java: add PUBSUB CHANNELS, NUMPAT and NUMSUB commands
#2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
reviewed
Aug 9, 2024
java/client/src/main/java/glide/api/commands/PubSubBaseCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
Aug 9, 2024
java/client/src/main/java/glide/api/commands/PubSubBaseCommands.java
Outdated
Show resolved
Hide resolved
| @@ -128,17 +131,23 @@ private BaseClient createClient(boolean standalone) { | |||
|
|
|||
| private static final int MESSAGE_DELIVERY_DELAY = 500; // ms | |||
|
|
|||
| @BeforeEach | |||
| @AfterEach | |||
There was a problem hiding this comment.
I don't know why, but is never called with @BeforeEach.
…s.java Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Aug 12, 2024
…alkey-178 Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2090
Requires binary impl for custom command - #2109, should be merged after it