Java: Add binary support to custom command. #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Aug 9, 2024
| * | ||
| * <p>The command will be routed to all primaries. | ||
| * subcommands, should be added as a separate value in <code>args</code>.<br> | ||
| * The command will be routed automatically based on the passed command's default request policy. |
There was a problem hiding this comment.
Is this correct?
What about commands that don't have a default request policy?
Users may ask where to find this default request policy... which we can't provide except through the code.
There was a problem hiding this comment.
I guess we should update https:/valkey-io/valkey-glide/wiki/General-Concepts#custom-command
There was a problem hiding this comment.
Yes, we should.
I copied this line from python/node docs.
Policy is defined in redis-rs in cluster_routing.rs
java/client/src/main/java/glide/api/commands/GenericClusterCommands.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
GumpacG
approved these changes
Aug 13, 2024
Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
…06-custom-bin Signed-off-by: Yury-Fridlyand <[email protected]>
…ll/glide-for-redis into java/yuryf-valkey-206-custom-bin Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
jonathanl-bq
approved these changes
Aug 14, 2024
acarbonetto
approved these changes
Aug 15, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update docs for custom command in python and node clients.
Isn't a breaking change, because
ReturnType/TResultalready includes a mapping from string toReturnType/TResult, which is equviavalent toClusterResponse<ReturnType>/TClusterResponse[TResult].