Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failing #2444

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix CI failing #2444

merged 1 commit into from
Oct 13, 2024

Conversation

shohamazon
Copy link
Collaborator

@shohamazon shohamazon commented Oct 13, 2024 •
edited
Loading

  • Replacing the installation of flake8, isort, and black with threeal/pipx-install-action.
  • Changing the AWS CLI installation to use sudo snap refresh and sudo snap install aws-cli --classic, removing unnecessary apt commands.

Issue link

This Pull Request is linked to issue (URL): #2447
Due to failing: https:/valkey-io/valkey-glide/actions/runs/11313325861/job/31462097795?pr=2372

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated. - not needed
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@shohamazon shohamazon marked this pull request as ready for review October 13, 2024 12:43
@shohamazon shohamazon requested a review from a team as a code owner October 13, 2024 12:43
avifenesh
avifenesh reviewed Oct 13, 2024
View reviewed changes
.github/workflows/start-self-hosted-runner/action.yml Outdated
@@ -24,7 +24,9 @@ runs:
shell: bash
run: |
sudo apt update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we using snap no need for the action on apt and apt-get

@shohamazon
Fix CI failing
1bfb4f7 
Signed-off-by: Shoham Elias <[email protected]>
@shohamazon shohamazon linked an issue Oct 13, 2024 that may be closed by this pull request
self-hosted runner and python linter ci failing #2447
Closed
@shohamazon shohamazon merged commit 705b404 into release-1.2 Oct 13, 2024
30 checks passed
@shohamazon shohamazon deleted the wf_fix branch October 13, 2024 14:27
Muhammad-awawdi-amazon pushed a commit that referenced this pull request Oct 14, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix CI failing (#2444)
6da2825 
Signed-off-by: Shoham Elias <[email protected]>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 15, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix CI failing (valkey-io#2444)
284c1b5 
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 16, 2024
Merged
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@shohamazon @avifenesh
Fix CI failing (valkey-io#2444)
c02a19e 
Signed-off-by: Shoham Elias <[email protected]>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@shohamazon @avifenesh
Fix CI failing (valkey-io#2444)
3962eeb 
Signed-off-by: Shoham Elias <[email protected]>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@shohamazon @Muhammad-awawdi-amazon
Fix CI failing (valkey-io#2444)
5895393 
Signed-off-by: Shoham Elias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avifenesh avifenesh avifenesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

self-hosted runner and python linter ci failing
2 participants
@shohamazon @avifenesh