Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python CI: fix linter installation #2465

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix python CI: fix linter installation #2465

merged 1 commit into from
Oct 16, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 16, 2024 •
edited
Loading

Replay #2444 which was reverted by #2456
Fixes CI failures:
https:/valkey-io/valkey-glide/actions/runs/11364202422/job/31638558098

Run black --check --diff .
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for '-t' / '--target-version': 'py311' is not one of 'py27', 'py33', 'py34', 'py35', 'py36', 'py37', 'py38', 'py39', 'py310'.
Error: Process completed with exit code 2.

Incorrect version of black was installed

@Yury-Fridlyand
fix ci
45e86d5 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added python CI CI/CD related labels Oct 16, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 16, 2024 20:24
@Yury-Fridlyand Yury-Fridlyand merged commit 1b6db03 into valkey-io:release-1.2 Oct 16, 2024
11 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/fix-py-linter branch October 16, 2024 21:20
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@Yury-Fridlyand @avifenesh
Fix python CI: fix linter installation (valkey-io#2465)
e5444b2 
fix ci

Signed-off-by: Yury-Fridlyand <[email protected]>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@Yury-Fridlyand @avifenesh
Fix python CI: fix linter installation (valkey-io#2465)
f0768ee 
fix ci

Signed-off-by: Yury-Fridlyand <[email protected]>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@Yury-Fridlyand @Muhammad-awawdi-amazon
Fix python CI: fix linter installation (valkey-io#2465)
6904c89 
fix ci

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@shohamazon shohamazon Awaiting requested review from shohamazon

Assignees
No one assigned
Labels
CI CI/CD related python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @acarbonetto @prateek-kumar-improving