Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactions get double/tripled counted much more often in recent TFs #3884

Closed
ara4n opened this issue Dec 16, 2020 · 1 comment
Closed

reactions get double/tripled counted much more often in recent TFs #3884

ara4n opened this issue Dec 16, 2020 · 1 comment
Assignees
@stefanceriu
Labels
A-Reactions A-Timeline Z-Papercuts Visible. Impactful. Predictable to action.
Milestone
iOS platform pape...

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2020

No description provided.

@pixlwave pixlwave added A-Reactions A-Timeline Z-Papercuts Visible. Impactful. Predictable to action. labels Jul 20, 2021
@stefanceriu stefanceriu self-assigned this Aug 10, 2021
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 10, 2021
@stefanceriu
Fixes element-hq/element-ios/issues/4507, element-hq/element-ios/issu…
62b1fda 
…es/3884 -  Updated reactions count from bundled relationship messages. Removes unnecesary send_relation rest method.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 11, 2021
@stefanceriu
Fixes element-hq/element-ios/issues/4507, element-hq/element-ios/issu…
86a6a03 
…es/3884 -  Updated reactions count from bundled relationship messages. Removes unnecesary send_relation rest method.
@pixlwave pixlwave added this to the iOS platform papercuts milestone Aug 17, 2021
@pixlwave
Copy link
Member

pixlwave commented Nov 5, 2021 •
edited
Loading

Reopening this issue as it still occurs. A quick way to reproduce is to increase the file store version.

The cause seems to be that -[MXAggregations resetData] is only called by -[MXKAccount closeSession:]
Where as -[MXFileStore deleteAllData] has 8 additional callers and so those cause the reactions to get incremented during the initial sync without having been reset.

@pixlwave pixlwave reopened this Nov 5, 2021
@pixlwave pixlwave mentioned this issue Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-Reactions A-Timeline Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
iOS platform papercuts (moved to http...
Development

No branches or pull requests
4 participants
@stefanceriu @ara4n @ismailgulek @pixlwave