Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

401 errors when you try to add an email address in Settings #3966

Closed
ara4n opened this issue Jan 23, 2021 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1000
Closed

401 errors when you try to add an email address in Settings #3966

ara4n opened this issue Jan 23, 2021 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1000
Assignees
@manuroe
Milestone
Sprint - Element ...

Comments

@ara4n
Copy link
Member

ara4n commented Jan 23, 2021

Screenshot 2021-01-23 at 00 45 39
@manuroe manuroe added this to the Sprint - Element 1.1.6 milestone Jan 25, 2021
@manuroe manuroe mentioned this issue Jan 25, 2021
Open
@manuroe
Copy link
Member

manuroe commented Jan 25, 2021

iOS is faulty because it does not use final values for sid and client_secret (code). There are static parameters that must be passed to every API call.
Synapse does not enforce yet that we pass final values for them but it does enforce a non empty client_secret now.

The quick fix is to use a random non empty string for client_secret.
The true fix will be managed in #3970.

@manuroe manuroe self-assigned this Jan 25, 2021
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 26, 2021
@manuroe
MX3PidAddManager: Use a non empty client_secret to discover /account/…
a5332c4 
…3pid/add flows

element-hq/element-ios/issues/3966

We need it because Synapse now checks that it is not empty.

The proper fix will be to use the same client_secret  (and sid) from the beginning of the authentication. But this will be done later with element-hq/element-ios#3970.
@manuroe manuroe mentioned this issue Jan 26, 2021
Merged
@ara4n
Copy link
Member Author

ara4n commented Jan 26, 2021

dup #3634 and #3571

This was referenced Jan 26, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
None yet
Projects
None yet
Milestone
Sprint - Element 1.1.7
2 participants
@ara4n @manuroe