Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Newick export with single quotes #441

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

gaurav
Copy link
Contributor

@gaurav gaurav commented Aug 30, 2023

This PR adds some tests and a possible, simple fix for #438.

Copy link
Member

@stevenweaver stevenweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think we should do a thorough job of escaping other special characters too. Let me see what I can do.

@gaurav
Copy link
Contributor Author

gaurav commented Oct 11, 2023

Awesome, thanks so much @stevenweaver! Please let me know if I can help in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants