Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): rewrite assets url in <noscript> #11764

Merged

Conversation

sapphi-red
Copy link
Member

Description

fixes #11735

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 20, 2023
@sapphi-red sapphi-red force-pushed the fix/rewrite-assets-url-in-noscript branch from 902a328 to a61c8a2 Compare January 20, 2023 10:16
@sapphi-red sapphi-red force-pushed the fix/rewrite-assets-url-in-noscript branch from a61c8a2 to eca9de0 Compare January 20, 2023 11:14
@bluwy bluwy changed the title fix: rewrite assets url in <noscript> fix(html): rewrite assets url in <noscript> Jan 20, 2023
@bluwy
Copy link
Member

bluwy commented Jan 20, 2023

Wrapped the PR title <noscript> with backticks so (I think) it should render properly when generating the changelog.

@patak-dev
Copy link
Member

Interesting choice for the default of scriptingEnabled on parse5

@patak-dev patak-dev merged commit 1dba285 into vitejs:main Feb 18, 2023
@sapphi-red sapphi-red deleted the fix/rewrite-assets-url-in-noscript branch February 18, 2023 12:48
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build for production: icon within noscript will not be relocated (index.html)
3 participants