Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode the 'root' group name, use the 'gid' for that. #219

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

buzzdeee
Copy link
Contributor

Non-Linux systems, i.e. *BSD might not have a group 'root', but
have group wheel.
What is in common everywhere is the 'gid' of these groups is '0'.

Setting the group => '0' instead of group => 'root' is a common
pattern seen in many other modules.

This fixes the setting of the group for the npmrc file.
For consistency, I also changed the group in manifests/repo/nodesource/yum.pp
even it doesn't affect me.

Ran into the problem on OpenBSD.

Non-Linux systems, i.e. *BSD might not have a group 'root', but
have group wheel.
What is in common everywhere is the 'gid' of these groups is '0'.

Setting the group => '0' instead of group => 'root' is a common
pattern seen in many other modules.

This fixes the setting of the group for the npmrc file.
For consistency, I also changed the group in manifests/repo/nodesource/yum.pp
even it doesn't affect me.

Ran into the problem on OpenBSD.
@igalic igalic merged commit 0576605 into voxpupuli:master Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants