Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hardcode the 'root' group name, use the 'gid' for that. #219

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Do not hardcode the 'root' group name, use the 'gid' for that. #219

merged 1 commit into from
Apr 21, 2016

Commits on Apr 21, 2016

  1. Do not hardcode the 'root' group name, use the 'gid' for that. 

    Non-Linux systems, i.e. *BSD might not have a group 'root', but
have group wheel.
What is in common everywhere is the 'gid' of these groups is '0'.

Setting the group => '0' instead of group => 'root' is a common
pattern seen in many other modules.

This fixes the setting of the group for the npmrc file.
For consistency, I also changed the group in manifests/repo/nodesource/yum.pp
even it doesn't affect me.

Ran into the problem on OpenBSD.
    @buzzdeee
    buzzdeee committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    3874378 View commit details
    Browse the repository at this point in the history