Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTimePicker): use window events instead of element #19523

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

blalan05
Copy link
Member

@blalan05 blalan05 commented Apr 1, 2024

Change the event handlers to use window events instead of limiting to picker container.

<template>
  <v-app>
    <v-main>
      <v-container>
        <v-row>
          {{ thisDate }}
          <v-col>
            <v-switch v-model="format24" color="primary" false-value="ampm" label="24hr" true-value="24hr" />
          </v-col>
          <v-col>
            <v-switch v-model="seconds" color="primary" label="Seconds" />
          </v-col>
        </v-row>
        <v-row>
          <v-col cols="12">
            <v-time-picker v-model="thisDate" :format="format24" :use-seconds="seconds" scrollable />
          </v-col>
        </v-row>
      </v-container>
    </v-main>
  </v-app>
</template>
<script setup>
  import { ref } from 'vue'

  const thisDate = ref(new Date())

  const format24 = ref('24hr')
  const seconds = ref(false)
</script>

@blalan05 blalan05 self-assigned this Apr 1, 2024
@blalan05 blalan05 added C: VTimePicker VTimePicker T: feature A new feature labels Apr 1, 2024
@blalan05 blalan05 linked an issue Apr 1, 2024 that may be closed by this pull request
@johnleider johnleider changed the title fix(VTimePicker): Fix #19508 use window events instead of element fix(VTimePicker): use window events instead of element Apr 9, 2024
@johnleider johnleider added this to the v3.5.x milestone Apr 9, 2024
@johnleider johnleider merged commit 73c3fb4 into master Apr 9, 2024
19 checks passed
@johnleider johnleider deleted the fix/v3-time-picker-window-events branch April 9, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTimePicker VTimePicker T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.13] VTimePicker ends drag on area-leave
2 participants