Remove dependency on parity_wasm from chisel CLI #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
opaque-module
branch
2 times, most recently
from
5ffe604
to
c6b402c
Compare
jakelang
reviewed
Sep 19, 2019
jakelang
reviewed
Sep 19, 2019
jakelang
reviewed
Sep 19, 2019
| @@ -3,7 +3,7 @@ extern crate binaryen; | |||
| extern crate parity_wasm; | |||
| extern crate rustc_hex; | |||
|
|
|||
| use parity_wasm::elements::Module; | |||
| pub use parity_wasm::elements::Module; | |||
There was a problem hiding this comment.
Not needed yet, but perhaps we could benefit from a prelude of sorts containing re-exports and the like.
jakelang
approved these changes
Sep 19, 2019
axic
commented
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #154. Also rolls back #150.