Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wazuh Handler: Stop agent/s ungracefully #61

Closed
pro-akim opened this issue Jun 16, 2023 · 11 comments · Fixed by #72
Closed

Wazuh Handler: Stop agent/s ungracefully #61

pro-akim opened this issue Jun 16, 2023 · 11 comments · Fixed by #72
Assignees
@pro-akim
Labels
level/task type/enhancement

Comments

@pro-akim
Copy link
Member

pro-akim commented Jun 16, 2023 •
edited
Loading

Description

Develop for qa-system-framework in WazuhHandler

  • Add to stop_agent a parameter that allows ungracefully stop an agent.
  • Add to stop_agents a parameter that allows ungracefully stop agents through a list of agents.
    The latter should consider the use of multithreading methods.
@pro-akim pro-akim self-assigned this Jun 28, 2023
pro-akim added a commit that referenced this issue Jun 28, 2023
@pro-akim
feature(#61): stopping agents ungracefully
a3338d7
@pro-akim pro-akim mentioned this issue Jun 28, 2023
Merged
pro-akim added a commit that referenced this issue Jun 28, 2023
@pro-akim
fix(#61): fixes after linter
62b6339
@pro-akim
Copy link
Member Author

28/06/2023

Methods stop_agent and stop_agents were changed adding a parameter "type" where default option is "gracefully", but it is possible to do it ungracefully

@pro-akim pro-akim linked a pull request Jun 28, 2023 that will close this issue
Stopping agents ungracefully feature #72
Merged
@pro-akim
Copy link
Member Author

pro-akim commented Jul 6, 2023

06/07/2023

Retesting was initiated but put on hold due to higher priority tasks (workload testing in release).

@pro-akim
Copy link
Member Author

pro-akim commented Jul 13, 2023 •
edited
Loading

Update

Review checked, Starting fixes.

@pro-akim
Copy link
Member Author

pro-akim commented Jul 13, 2023 •
edited
Loading

Update

Changes done.
Starting with tests before pending review.

pro-akim added a commit that referenced this issue Jul 13, 2023
@pro-akim
fix(#61): changes after review
ab390ad
@pro-akim
Copy link
Member Author

pro-akim commented Jul 13, 2023 •
edited
Loading

Update

Test performed OK.
Changing to pending review.

@pro-akim
Copy link
Member Author

Update

Starting fixes after Review

pro-akim added a commit that referenced this issue Jul 28, 2023
@pro-akim
fix(#61): fixes done after review
1d588e9
@pro-akim
Copy link
Member Author

Update

Moved to pending review.
Changes done

pro-akim added a commit that referenced this issue Nov 15, 2023
@pro-akim
merge(#61): Merge
c6bdecf
@pro-akim
Copy link
Member Author

Update

Conflicts were solved.

@Rebits
Copy link
Member

Rebits commented Nov 21, 2023

Delayed ETA to 22, in order to allow a review of the applied changes

pro-akim added a commit that referenced this issue Nov 22, 2023
@pro-akim
fix(#61): remove library and add become
96dda29
@pro-akim
Copy link
Member Author

Update

Required changes done

@davidjiglesias
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pro-akim pro-akim

Labels
level/task type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stopping agents ungracefully feature wazuh/qa-system-framework
3 participants
@Rebits @davidjiglesias @pro-akim