Stopping agents ungracefully feature #72

pro-akim · 2023-06-28T12:46:02Z

Related Issue
#61

Description

This PR includes additional parameters for stop_agent and stop_agents, making possible to stop them ungracefully

Evidences

Running:

wh.stop_agent("agent1", type='gracefully')
wh.stop_agent("agent1", type='ungracefully')
wh.stop_agents(["agent1", "agent2"], type='gracefully', parallel=True)
wh.stop_agents(["agent1", "agent2"], type='ungracefully', parallel=True)
wh.stop_agents(["agent1", "agent2"], type='gracefully', parallel=False)
wh.stop_agents(["agent1", "agent2"], type='ungracefully', parallel=False)

Results:

agent1 stopped gracefully
agent1 stopped ungracefully
agent1 and agent2 stopped gracefully
agent1 and agent2 stopped ungracefully
agent1 and agent2 stopped gracefully one by one
agent1 and agent2 stopped ungracefully one by one

BelenValdivia · 2023-07-03T19:19:04Z

@pro-akim Check the failing unit tests

pro-akim · 2023-07-05T08:50:33Z

05/07/2023

Checks were done before the PR, however, it will be tested one more time when the pipeline is back. It will remain on on-hold status.

pro-akim · 2023-07-06T16:47:32Z

Evidences

Running:

wh.stop_agent("agent1", type='gracefully')
wh.stop_agent("agent1", type='ungracefully')
wh.stop_agents(["agent1", "agent2"], type='gracefully', parallel=True)
wh.stop_agents(["agent1", "agent2"], type='ungracefully', parallel=True)
wh.stop_agents(["agent1", "agent2"], type='gracefully', parallel=False)
wh.stop_agents(["agent1", "agent2"], type='ungracefully', parallel=False)

Results:

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-14-219.ec2.internal (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-4-68, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-14-219.ec2.internal (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-4-68, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-6-43 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-2-206, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-6-43 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-2-206, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-6-43 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-2-206, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-6-43 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-2-206, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Unit tests seem to be ok

BelenValdivia · 2023-07-10T14:48:29Z

PR checks still failing

pro-akim · 2023-07-11T08:18:05Z

11/07/2023

Automatically triggered unit tests detect failures in code that was not modified by this issue.
It will be researched.

pro-akim · 2023-07-11T13:41:56Z

11/07/2023

The status code was 403 (certificate problems).
After a new run, unit tests have passed successfully.

src/wazuh_qa_framework/system/wazuh_handler.py

pro-akim · 2023-07-13T11:31:38Z

Evidences

Running:

wh.stop_agent("agent1", gracefully=True)
wh.stop_agent("agent1", gracefully=False)
wh.stop_agents(["agent1", "agent2"], gracefully=True , parallel=True)
wh.stop_agents(["agent1", "agent2"], gracefully=False, parallel=True)
wh.stop_agents(["agent1", "agent2"], gracefully=True, parallel=False)
wh.stop_agents(["agent1", "agent2"], gracefully=False, parallel=False)

Results:

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-0-95 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-6-8, IP: any, Disconnected
   ID: 002, Name: EC2AMAZ-2BV3AJS, IP: any, Disconnected

Unit tests seem to be ok

src/wazuh_qa_framework/system/wazuh_handler.py

src/wazuh_qa_framework/system/host_manager.py

pro-akim · 2023-07-28T09:13:21Z

Update

Changes done.
Ready to be reviewed.

src/wazuh_qa_framework/system/host_manager.py

src/wazuh_qa_framework/system/wazuh_handler.py

Rebits

Some minor final changes are requested

src/wazuh_qa_framework/system/host_manager.py

src/wazuh_qa_framework/system/wazuh_handler.py

pro-akim · 2023-11-16T17:51:54Z

Update

Tested and fixed:

Evidences

Running:

wh.stop_agent("agent1", gracefully=True)
wh.stop_agent("agent1", gracefully=False)
wh.stop_agents(["agent1", "agent2"], gracefully=True , parallel=True)
wh.stop_agents(["agent1", "agent2"], gracefully=False, parallel=True)
wh.stop_agents(["agent1", "agent2"], gracefully=True, parallel=False)
wh.stop_agents(["agent1", "agent2"], gracefully=False, parallel=False)

Results:

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Active

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Disconnected

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Disconnected

Stopped one by one

Wazuh agent_control. List of available agents:
   ID: 000, Name: ip-172-31-9-178 (server), IP: 127.0.0.1, Active/Local
   ID: 001, Name: ip-172-31-3-59, IP: any, Disconnected
   ID: 002, Name: DESKTOP-AQ2R8SM, IP: any, Disconnected

Unit tests seem to be ok

src/wazuh_qa_framework/system/wazuh_handler.py

src/wazuh_qa_framework/system/host_manager.py

Rebits

LGTM

feature(#61): stopping agents ungracefully

a3338d7

pro-akim self-assigned this Jun 28, 2023

fix(#61): fixes after linter

62b6339

pro-akim linked an issue Jun 28, 2023 that may be closed by this pull request

Wazuh Handler: Stop agent/s ungracefully #61

Closed

pro-akim requested review from Rebits and juliamagan and removed request for Rebits July 6, 2023 16:49

pro-akim marked this pull request as draft July 11, 2023 08:18

pro-akim marked this pull request as ready for review July 11, 2023 13:37

pro-akim marked this pull request as draft July 11, 2023 13:37

pro-akim marked this pull request as ready for review July 11, 2023 13:42

BelenValdivia approved these changes Jul 11, 2023

View reviewed changes

Rebits requested changes Jul 11, 2023

View reviewed changes

fix(#61): changes after review

ab390ad

pro-akim requested review from BelenValdivia and Rebits July 13, 2023 11:34

BelenValdivia approved these changes Jul 17, 2023

View reviewed changes

Rebits requested changes Jul 27, 2023

View reviewed changes

src/wazuh_qa_framework/system/host_manager.py Outdated Show resolved Hide resolved

fix(#61): fixes done after review

1d588e9

pro-akim requested a review from Rebits July 28, 2023 09:11

damarisg requested changes Oct 4, 2023

View reviewed changes

src/wazuh_qa_framework/system/host_manager.py Outdated Show resolved Hide resolved

src/wazuh_qa_framework/system/wazuh_handler.py Show resolved Hide resolved

merge(#61): Merge

c6bdecf

pro-akim requested a review from damarisg November 15, 2023 14:59

pro-akim marked this pull request as draft November 15, 2023 15:03

pro-akim marked this pull request as ready for review November 15, 2023 15:04

Rebits requested changes Nov 16, 2023

View reviewed changes

src/wazuh_qa_framework/system/host_manager.py Outdated Show resolved Hide resolved

src/wazuh_qa_framework/system/wazuh_handler.py Outdated Show resolved Hide resolved

src/wazuh_qa_framework/system/wazuh_handler.py Outdated Show resolved Hide resolved

fix(#60): Fixes after review

1ebf890

pro-akim requested a review from Rebits November 16, 2023 17:52

Rebits requested changes Nov 22, 2023

View reviewed changes

src/wazuh_qa_framework/system/wazuh_handler.py Outdated Show resolved Hide resolved

src/wazuh_qa_framework/system/host_manager.py Outdated Show resolved Hide resolved

fix(#61): remove library and add become

96dda29

pro-akim requested a review from Rebits November 22, 2023 10:54

Rebits approved these changes Nov 22, 2023

View reviewed changes

davidjiglesias merged commit 340bd6d into system-refactor Nov 22, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stopping agents ungracefully feature #72

Stopping agents ungracefully feature #72

pro-akim commented Jun 28, 2023

BelenValdivia commented Jul 3, 2023

pro-akim commented Jul 5, 2023

pro-akim commented Jul 6, 2023 •

edited

Loading

BelenValdivia commented Jul 10, 2023

pro-akim commented Jul 11, 2023 •

edited

Loading

pro-akim commented Jul 11, 2023

pro-akim commented Jul 13, 2023 •

edited

Loading

pro-akim commented Jul 28, 2023

Rebits left a comment

pro-akim commented Nov 16, 2023

Rebits left a comment

Stopping agents ungracefully feature #72

Stopping agents ungracefully feature #72

Conversation

pro-akim commented Jun 28, 2023

Description

Evidences

BelenValdivia commented Jul 3, 2023

pro-akim commented Jul 5, 2023

05/07/2023

pro-akim commented Jul 6, 2023 • edited Loading

Evidences

BelenValdivia commented Jul 10, 2023

pro-akim commented Jul 11, 2023 • edited Loading

11/07/2023

pro-akim commented Jul 11, 2023

11/07/2023

pro-akim commented Jul 13, 2023 • edited Loading

Evidences

pro-akim commented Jul 28, 2023

Update

Rebits left a comment

Choose a reason for hiding this comment

pro-akim commented Nov 16, 2023

Update

Evidences

Rebits left a comment

Choose a reason for hiding this comment

pro-akim commented Jul 6, 2023 •

edited

Loading

pro-akim commented Jul 11, 2023 •

edited

Loading

pro-akim commented Jul 13, 2023 •

edited

Loading