Skip to content

Commit

Permalink
[backport 4.4-7.10]Fix filtering of not applicable SCA checks using…
Browse files Browse the repository at this point in the history
… `result` filter (#5083)

Fix filtering of `not applicable` SCA checks using `result` filter (#5031)

* fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar

* fix(sca): sort the filters keys in the suggestions of the SCA checks search bar

* changelog: add the pull request entry

* fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value.

* fix: unify the SCA check result label name

* changelog: add pull request entry

* fix: update the API data (endpoints and security actions)

Co-authored-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
(cherry picked from commit dd81bc6)

Co-authored-by: Antonio <[email protected]>
  • Loading branch information
chantal-kelm and Desvelao authored Jan 6, 2023
1 parent 8b7a115 commit 825430d
Show file tree
Hide file tree
Showing 7 changed files with 700 additions and 335 deletions.
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ All notable changes to the Wazuh app project will be documented in this file.
- Added cluster's IP and protocol as suggestions in the agent deployment wizard. [#4776](https:/wazuh/wazuh-kibana-app/pull/4776) [#4954](https:/wazuh/wazuh-kibana-app/pull/4954)
- Show OS name and OS version in the agent installation wizard. [#4851](https:/wazuh/wazuh-kibana-app/pull/4851)
- Changed the endpoint that updates the plugin configuration to support multiple settings. [#4501](https:/wazuh/wazuh-kibana-app/pull/4501)
- The button to export the app logs is now disabled when there are no results, instead of showing an error toast [#4972](https:/wazuh/wazuh-kibana-app/pull/4972)
- Updated the `winston` dependency to `3.5.1` [#5014](https:/wazuh/wazuh-kibana-app/pull/5014)
- Updated the `winston` dependency to `3.5.1` [#4985](https:/wazuh/wazuh-kibana-app/pull/4985)
- Updated the `pdfmake` dependency to `0.2.6` [#4985](https:/wazuh/wazuh-kibana-app/pull/4985)
- The button to export the app logs is now disabled when there are no results, instead of showing an error toast [#4992](https:/wazuh/wazuh-kibana-app/pull/4992)
- Unify the SCA check result label name [#5031](https:/wazuh/wazuh-kibana-app/pull/5031)

### Fixed

Expand All @@ -53,6 +55,7 @@ All notable changes to the Wazuh app project will be documented in this file.
- Raspbian OS, Ubuntu, Amazon Linux and Amazon Linux 2 commands in the wizard deploy agent now change when a different architecture is selected [#4876](https:/wazuh/wazuh-kibana-app/pull/4876) [#4880](https:/wazuh/wazuh-kibana-app/pull/4880)
- Disabled unmapped fields filter in Security Events alerts table [#4929](https:/wazuh/wazuh-kibana-app/pull/4929)
- Fixed the manager option in the agent deployment section [#4981](https:/wazuh/wazuh-kibana-app/pull/4981)
- Fixed Inventory checks table filters by stats [#4999](https:/wazuh/wazuh-kibana-app/pull/4999) [#5031](https:/wazuh/wazuh-kibana-app/pull/5031)
- Fixed commands in the deploy new agent section(most of the commands are missing '-1') [#4962](https:/wazuh/wazuh-kibana-app/pull/4962)
- Fixed agent installation command for macOS in the deploy new agent section. [#4968](https:/wazuh/wazuh-kibana-app/pull/4968)
- Deploy new agent section: Fixed the way macos versions and architectures were displayed, fixed the way agents were displayed, fixed the way ubuntu versions were displayed. [#4933](https:/wazuh/wazuh-kibana-app/pull/4933)
Expand Down
627 changes: 440 additions & 187 deletions common/api-info/endpoints.json

Large diffs are not rendered by default.

22 changes: 22 additions & 0 deletions common/api-info/security-actions.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"GET /agents/{agent_id}/config/{component}/{configuration}",
"GET /agents/{agent_id}/group/is_sync",
"GET /agents/{agent_id}/key",
"GET /agents/{agent_id}/daemons/stats",
"GET /agents/{agent_id}/stats/{component}",
"GET /groups/{group_id}/agents",
"GET /agents/no_group",
Expand Down Expand Up @@ -280,10 +281,12 @@
"GET /cluster/local/info",
"GET /cluster/nodes",
"GET /cluster/healthcheck",
"GET /cluster/ruleset/synchronization",
"GET /cluster/local/config",
"GET /cluster/{node_id}/status",
"GET /cluster/{node_id}/info",
"GET /cluster/{node_id}/configuration",
"GET /cluster/{node_id}/daemons/stats",
"GET /cluster/{node_id}/stats",
"GET /cluster/{node_id}/stats/hourly",
"GET /cluster/{node_id}/stats/weekly",
Expand Down Expand Up @@ -505,6 +508,7 @@
"GET /manager/status",
"GET /manager/info",
"GET /manager/configuration",
"GET /manager/daemons/stats",
"GET /manager/stats",
"GET /manager/stats/hourly",
"GET /manager/stats/weekly",
Expand Down Expand Up @@ -1085,6 +1089,24 @@
"GET /tasks/status"
]
},
"vulnerability:run": {
"description": "Allow running a vulnerability detector scan",
"resources": [
"*:*"
],
"example": {
"actions": [
"vulnerability:run"
],
"resources": [
"*:*:*"
],
"effect": "allow"
},
"related_endpoints": [
"PUT /vulnerability"
]
},
"vulnerability:read": {
"description": "Allow reading agents' vulnerabilities information",
"resources": [
Expand Down
7 changes: 7 additions & 0 deletions common/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1919,3 +1919,10 @@ export enum HTTP_STATUS_CODES {
INSUFFICIENT_STORAGE = 507,
NETWORK_AUTHENTICATION_REQUIRED = 511
}

// Module Security configuration assessment
export const MODULE_SCA_CHECK_RESULT_LABEL = {
passed: 'Passed',
failed: 'Failed',
'not applicable': 'Not applicable'
}
Loading

0 comments on commit 825430d

Please sign in to comment.