Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 4.4-7.10]Fix filtering of not applicable SCA checks using result filter #5083

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

chantal-kelm
Copy link
Member

Backport bf7fbb4 from #5031.

…5031)

* fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar

* fix(sca): sort the filters keys in the suggestions of the SCA checks search bar

* changelog: add the pull request entry

* fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value.

* fix: unify the SCA check result label name

* changelog: add pull request entry

* fix: update the API data (endpoints and security actions)

Co-authored-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
(cherry picked from commit dd81bc6)
@chantal-kelm chantal-kelm requested a review from a team as a code owner January 6, 2023 15:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Code coverage (Jest) % values
Statements 8.76% ( 3242 / 37003 )
Branches 4.54% ( 1306 / 28738 )
Functions 7.67% ( 703 / 9170 )
Lines 8.83% ( 3127 / 35430 )

@yenienserrano yenienserrano changed the title Fix filtering of not applicable SCA checks using result filter [backport 4.4-7.10]Fix filtering of not applicable SCA checks using result filter Jan 6, 2023
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

@yenienserrano yenienserrano merged commit 825430d into 4.4-7.10 Jan 6, 2023
@yenienserrano yenienserrano deleted the backport-5031-to-4.4-7.10 branch January 6, 2023 15:27
@yenienserrano yenienserrano linked an issue Jan 6, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not applicable SCA checks should be filtered by result
3 participants