Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not applicable SCA checks should be filtered by result #5027

Closed
2 tasks done
Desvelao opened this issue Dec 21, 2022 · 1 comment · Fixed by #5031, #5083 or #5082
Closed
2 tasks done

Not applicable SCA checks should be filtered by result #5027

Desvelao opened this issue Dec 21, 2022 · 1 comment · Fixed by #5031, #5083 or #5082
Assignees
Labels
type/bug Bug issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Dec 21, 2022

Wazuh Elastic Rev Security
4.x 7.x 4xxx Basic, ODFE, Xpack
Browser
Chrome, Firefox, Safari, etc

Description
In a recent meeting, the API , core and frontend teams agree to apply changes in how the plugin should get the checks that are not applicable.

The core team and framework team will do changes to the result and status fields that are merged into one field. So the possible values for the result field can be:

  • passed
  • failed
  • not applicable

With this change, we can use the API endpoint to get the not applicable SCA checks through the result query parameter in the API endpoint:

GET /sca/:agent_id/checks/:policy_id?result=<result>

This issue is related to:

Tasks:

  • Change the Not applicable filter that is added from the stat to use result instead of the previously applied workaround of using the status: not applicable query parameter.
  • Review the new API response and adapt the UI. If some field was removed after these changes, we should adapt to not use some fields that is not available

Preconditions
1.

Steps to reproduce

  1. Navigate to '...'
  2. Click on '....'
  3. Scroll down to '....'

Expected Result

  1. Click in the Not applicable stat should
  • The filter added to the search bar should be result: not applicable or something like that (depending on the query parameter to use)
  • The API request should use the result query parameter

Actual Result
We changed to use the status query parameter with not applicable value as a workaround in this pull request: #4999

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. Here you can paste log entries too or any other useful information that may help with the issue.

@Desvelao
Copy link
Member Author

Changes

  • Use the result query parameter to filters the SCA checks are not applicable
  • Remove the status filter in the search bar

Side changes

  • Sort the filter keys suggestion in the search bar of SCA checks table
  • Unify the SCA check result label name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment