Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the agent installation command for macOS #4968

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 6, 2022

Description

This PR fixes the agent installation command for macOS

This pull request is going to be merged into the main branch used for this epic #4931

Manual Backports

4.4-2.3-wzd
4.4-7.16

Issues Resolved

#4953

Evidence

image

Steps to test

  • Click on agents
  • Click deploy new agent
  • Follow the steps to deploy a new macOS agent
  • In the step 'Install and enroll agent' the variables WAZUH_MANAGER, WAZUH_AGENT_GROUP and WAZUH_AGENT_NAME *should not contain a '=' sign.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner December 6, 2022 18:27
Copy link
Member

@davidjiglesias davidjiglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is spanish in the changelog, please fix.

@AlexRuiz7 AlexRuiz7 changed the title Fixed the agent installation command for macOS Fix the agent installation command for macOS Dec 13, 2022
Mayons95
Mayons95 previously approved these changes Dec 15, 2022
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️

LGTM

Screenshot from 2022-12-15 11-05-33

Desvelao
Desvelao previously approved these changes Dec 16, 2022
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

✔️ code
✔️ code

Screenshot
image

@Desvelao Desvelao changed the base branch from 4931-fix-section-deploy-new-agent to 4.4-7.10 December 16, 2022 15:57
@Desvelao Desvelao dismissed stale reviews from Mayons95 and themself December 16, 2022 15:57

The base branch was changed.

@Desvelao Desvelao changed the base branch from 4.4-7.10 to 4931-fix-section-deploy-new-agent December 16, 2022 15:59
@Desvelao Desvelao merged commit 072e873 into 4931-fix-section-deploy-new-agent Dec 16, 2022
@Desvelao Desvelao deleted the 4953-Fix-agent-installation-command-for-macOS branch December 16, 2022 16:01
chantal-kelm added a commit that referenced this pull request Dec 21, 2022
* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md
chantal-kelm added a commit that referenced this pull request Dec 22, 2022
* accordion and alpine os

* changes

* changes

* changes

* changes

* alpine versions commands

* commands for alpine and architecture macos

* message install and start alpine

* CHANGELOG

* command debian

* command raspbian

* Added link for additional steps to alpine os and changelog

* clear code

* clean code

* fixed windows command

* deploy new agent section: command fixed for solaris

* Fix the agent installation command for macOS (#4968)

* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md

* Fix agent deployment instructions for HP-UX and Solaris (#4943)

* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog

* red hat, centos and windows commands fixed

* Deploy new agent section: change the commands for all os

* Deploy new agent section: change commands for all os

* clean code

* update commands

* Deploy new agents: Update commands

* Deploy new agents: Update commands

* comand windows

* oracleLinux command

* warningcOMAND

Co-authored-by: Álex <[email protected]>
chantal-kelm added a commit that referenced this pull request Dec 22, 2022
* accordion and alpine os

* changes

* changes

* changes

* changes

* alpine versions commands

* commands for alpine and architecture macos

* message install and start alpine

* CHANGELOG

* command debian

* command raspbian

* Added link for additional steps to alpine os and changelog

* clear code

* clean code

* fixed windows command

* deploy new agent section: command fixed for solaris

* Fix the agent installation command for macOS (#4968)

* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md

* Fix agent deployment instructions for HP-UX and Solaris (#4943)

* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog

* red hat, centos and windows commands fixed

* Deploy new agent section: change the commands for all os

* Deploy new agent section: change commands for all os

* clean code

* update commands

* Deploy new agents: Update commands

* Deploy new agents: Update commands

* comand windows

* oracleLinux command

* warningcOMAND

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 549edd0)
chantal-kelm added a commit that referenced this pull request Dec 22, 2022
* Fix deploy new agent section (#4933)

* accordion and alpine os

* changes

* changes

* changes

* changes

* alpine versions commands

* commands for alpine and architecture macos

* message install and start alpine

* CHANGELOG

* command debian

* command raspbian

* Added link for additional steps to alpine os and changelog

* clear code

* clean code

* fixed windows command

* deploy new agent section: command fixed for solaris

* Fix the agent installation command for macOS (#4968)

* Fixed the agent installation command for macOS

* CHANGELOG

* Update CHANGELOG.md

* Fix agent deployment instructions for HP-UX and Solaris (#4943)

* removing auto-deploy variables in hp and solaris

* hide wazuh server address sections, assign group and assign name to agent when os is hp or solaris

* update hp command

* removing auto-deploy variables in alpine

* move message additional installation steps

* links and messages os

* changelog

* red hat, centos and windows commands fixed

* Deploy new agent section: change the commands for all os

* Deploy new agent section: change commands for all os

* clean code

* update commands

* Deploy new agents: Update commands

* Deploy new agents: Update commands

* comand windows

* oracleLinux command

* warningcOMAND

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 549edd0)

* styles

* hp command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS agent installation command fails due to launchctl setenv
4 participants