Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QACTL: Improve Docker image generation process #1749

Closed
3 tasks done
fernandolojano opened this issue Aug 23, 2021 · 3 comments
Closed
3 tasks done

QACTL: Improve Docker image generation process #1749

fernandolojano opened this issue Aug 23, 2021 · 3 comments
Assignees

Comments

@fernandolojano
Copy link
Contributor

fernandolojano commented Aug 23, 2021

This issue has been created with the purpose of improving the current docker image generation process of the qactl deployment section.
As for now, in order to generate a specific docker image (those given in the directory dockerfiles), we have to follow the next steps:

  • Copy the dockerfile we want to use and the entrypoint.sh in a different directory .
  • Change the name of the specific dockerfile to Dockerfile.
  • In the conf.yaml file we have to declare the directory path where the files were copied.

The first two steps given have to be done manually. A new implementation for generating a docker image is needed in order to avoid this manual process.

Tasks

  • Investigate about different approaches for an automatic docker image generator process
  • Modify schema file for new possible parameters
  • Modify current docker image generator implementation
@fernandolojano
Copy link
Contributor Author

fernandolojano commented Aug 23, 2021

This new changes are being made in the branch 1749-improve-docker-generator

@fernandolojano
Copy link
Contributor Author

The first approach implemented seems to work fine. However, it's not completed yet, there are some minor changes that still need to be added:

  • After talking about some adjustments, It has been decided creating a python dictionary where the different Dockerfiles will be listed in order to have an easier access to them when adding this parameter in the conf.yaml file.
  • The temp files and directories need to be deleted after being used.

@fernandolojano
Copy link
Contributor Author

fernandolojano commented Aug 24, 2021

The previous methodology implemented for improving the docker image generator has been discarded. Now, after checking that the image is been generated properly and checking the correct validation of the conf.yaml for the docker deployment section, there has been made some changes in the schema.

  • ports : The format has been chosen following the docker-py documentation. In this documentation, ports is a field with the form of a python dictionary where the keys are the ports to bind inside the container in the form port/protocol, and the values are integers corresponding to the ports we want to open in the host. A valid entry would be: ports: {'1526/tcp': 1526}

Regarding the new docker image generation process, no new modifications were added as the new methodology works correctly and shows the proper errors wether if the dockerfile does not exists or the path given doesn't lead to any dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants