Improve img docker generation process #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandolojano
changed the title
jmv74211
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is necessary to improve the docker img generation process and check that the validation step works properly. In order to achieve these goals, the file system has been restructured and the schema has been modified.
This PR makes the following changes:
Restructure
dockerfilesdirectory organizationModify JSON schema validator file.
The docker img generator process is automatic now
The validation process accepts all the possible parameters now
Checks
All the steps followed in order to achieve the goals are commented in the issue related above. Plus, the last modifications can be read in this comment