Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_assign_groups_guess #3863

Closed
juliamagan opened this issue Jan 27, 2023 · 0 comments · Fixed by #3901
Closed

Improve test_assign_groups_guess #3863

juliamagan opened this issue Jan 27, 2023 · 0 comments · Fixed by #3901
Assignees

Comments

@juliamagan
Copy link
Member

juliamagan commented Jan 27, 2023

Description

After the research done in #3776, we could see that test_assign_groups_guess is stable. However, it takes 21 minutes to finish the test execution. We need to reduce this time.

In addition, after the research done in #3876, we saw that we could improve the test by checking the following logs:

  • Worker
2023/02/01 13:40:28 wazuh-remoted[1718] manager.c:556 at assign_group_to_agent_worker(): DEBUG: Sending message to master node: '{"daemon_name":"remoted","message":{"command":"assigngroup","parameters":{"agent":"060","md5":"x"}}}'
2023/02/01 13:40:28 wazuh-remoted[1718] manager.c:560 at assign_group_to_agent_worker(): DEBUG: Message received from master node: '{"error":0,"message":"ok","data":{"group":"default"}}'
2023/02/01 13:40:28 wazuh-remoted[1718] manager.c:1598 at wait_for_msgs(): DEBUG: Sending file 'default/merged.mg' to agent '060'.
2023/02/01 13:40:28 wazuh-remoted[1718] manager.c:1614 at wait_for_msgs(): DEBUG: End sending file 'default/merged.mg' to agent '060'.
  • Master
2023/02/01 13:40:28 wazuh-remoted[1877] manager.c:508 at assign_group_to_agent(): DEBUG: Agent '060' with file 'merged.mg' MD5 'x'
2023/02/01 13:40:28 wazuh-remoted[1877] manager.c:527 at assign_group_to_agent(): DEBUG: Group assigned: 'default'
@juliamagan juliamagan self-assigned this Jan 27, 2023
@juliamagan juliamagan changed the title Reduce execution time of test_assign_groups_guess Improve test_assign_groups_guess Feb 2, 2023
@juliamagan juliamagan linked a pull request Feb 7, 2023 that will close this issue
juliamagan added a commit that referenced this issue Feb 7, 2023
juliamagan added a commit that referenced this issue Feb 8, 2023
juliamagan added a commit that referenced this issue Feb 8, 2023
juliamagan added a commit that referenced this issue Feb 8, 2023
jmv74211 pushed a commit that referenced this issue Feb 9, 2023
* refactor(#3863): check expected logs

* feat(#3863): update changelog

* feat(#3863): add messages

* fix(#3863): fix linter errors

* fix(#3863): fix linter errors
@jmv74211 jmv74211 closed this as completed Feb 9, 2023
Deblintrake09 pushed a commit that referenced this issue Apr 24, 2023
* refactor(#3863): check expected logs

* feat(#3863): update changelog

* feat(#3863): add messages

* fix(#3863): fix linter errors

* fix(#3863): fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants