Analysisd

fernandolojano · 2021-12-24T12:02:35Z

Related issue
#1850

Description

closes #1850

This PR adds a new test for Analysisd requested on the issue #1850. As for now, it works properly as it's able to detect the changes of the file time and inode whenever
they change.

This test check:

The Inode value of the queue socket can't change after the Analysisd daemon is set in the testing configuration mode
The File time value of the queue socket can't change after the Analysisd daemon is set in the testing configuration mode

Tests

Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
Python codebase is documented following the Google Style for Python docstrings.
The test is documented in wazuh-qa/docs.
provision_documentation.sh generate the docs without errors.

tests/integration/test_analysisd/test_queue_socket_properties/test_queue_socket_properties.py

mauromalara · 2021-12-31T22:09:17Z

CentOS: Manager	Local	Jenkins
PS1	🔴	🔴
PS2	🔴	🔴
PS3	🔴	🔴

Note
It fails apparently because the bug was not fixed
@fernandolojano please, check the results with the core team to determine if is an error or a bug of Wazuh.

I didn't merge master in the current branhc

mauromalara

@fernandolojano please, modify the code following the PEP8 guidelines. You can follow this guide to doing it, take into account that you must change the max-line-length argument following this guide

mauromalara · 2022-02-03T22:05:11Z

03/02/2022

Package

Version	Revision	Link
4.4.0	0.40400.20220202	package

Testing

OS	Local	Jenkins	Notes
R1	🔴	🔴 - Build	Local failure: The inode value for the socket `/var/ossec/queue/sockets/queue` has changed -- Jenkins failure: The modification time property value for the socket `/var/ossec/queue/sockets/queue` has changed
R2	🔴	🔴 - Build	Same as before
R3	🔴	🔴 - Build	Same as before

NOTES (important)
@snaow it seems that the bug was not fixed. This may be a stopper. The test fails in both executions. In Jenkins, the `mtime` changes but locally the `inode` changes instead. The package used is the same.

jnasselle

There's no stopper and this could be validated by manual testing (ls -li to get inodes and stat -c '%y' to get modification time).
I propose a rearrangement of this test in the next branch: https:/wazuh/wazuh-qa/tree/fix-1850-check-queue-socket-status-test

Jenkins: Tested using v4.2.2 staging packages
Local: Tested using v4.4.0 source installation

CentOS: Manager	Local	Jenkins
PS1	🟢	🟢
PS2	🟢	🟢
PS3	🟢	🟢

Hope this helps!
Nico

mauromalara · 2022-02-21T19:42:09Z

There's no stopper and this could be validated by manual testing (ls -li to get inodes and stat -c '%y' to get modification time). I propose a rearrangement of this test in the next branch: https:/wazuh/wazuh-qa/tree/fix-1850-check-queue-socket-status-test

Jenkins: Tested using v4.2.2 staging packages Local: Tested using v4.4.0 source installation

CentOS: Manager Local Jenkins
PS1 green_circle green_circle
PS2 green_circle green_circle
PS3 green_circle green_circle
Hope this helps! Nico

Hi @jnasselle,

Thanks for your help, I'll check it and apply the necessary changes.

mauromalara · 2022-02-21T22:21:59Z

21/02/2022

Packages

Local

Version	Revision	Link
4.4.0	0.40400.20220202	package

Jenkins

v4.2.2 - Staging

Testing

CentOS: Manager	Local	Jenkins
PS1	🟢	🟢
PS2	🟢	🟢
PS3	🟢	🟢

Rebits

GJ, but some changes are required

CHANGELOG.md

deps/wazuh_testing/wazuh_testing/db_interface/__init__.py

tests/integration/test_analysisd/test_queue_socket_properties/test_queue_socket_properties.py

mauromalara · 2022-03-14T23:47:41Z

14/03/2022

Package

Version	Revision	Link
4.4.0	0.40400.20220202	download

Testing

Analysisd

CentOS	Local	Jenkins
R1	🟢	🟢 - Build
R2	🟢	🟢 - Build
R3	🟢	🟢 - Build

Rebits · 2022-03-16T10:18:22Z

16/03/2022

Package

Version	Revision	Link
4.3.0	1	https://packages-dev.wazuh.com/pre-release/yum/wazuh-manager-4.3.0-1.x86_64.rpm

Testing

`test_analysisd`

OS	Local	Notes
R1	🟢
R2	🟢
R3	🟢

🟢: All pass
🟡: Some warnings
🔴: Some errors/fails
🔵: In progress

…queue_socket_properties Co-authored-by: mauromalara <[email protected]>

Rebits

LGTM

fernandolojano added the subteam/qa-earthquake label Dec 24, 2021

fernandolojano self-assigned this Dec 24, 2021

fernandolojano requested review from mauromalara and snaow December 27, 2021 08:15

mauromalara suggested changes Dec 27, 2021

View reviewed changes

fernandolojano requested a review from mauromalara December 28, 2021 09:17

mauromalara suggested changes Dec 28, 2021

View reviewed changes

tests/integration/test_analysisd/test_queue_socket_properties/test_queue_socket_properties.py Outdated Show resolved Hide resolved

fernandolojano requested a review from mauromalara January 7, 2022 08:50

mauromalara previously approved these changes Jan 17, 2022

View reviewed changes

mauromalara self-requested a review January 17, 2022 15:53

mauromalara suggested changes Jan 17, 2022

View reviewed changes

mauromalara previously approved these changes Jan 21, 2022

View reviewed changes

mauromalara dismissed their stale review via 829de5d January 31, 2022 13:19

mauromalara requested review from mauromalara and removed request for mauromalara January 31, 2022 13:39

mauromalara assigned mauromalara and unassigned fernandolojano Feb 3, 2022

mauromalara previously approved these changes Feb 3, 2022

View reviewed changes

jnasselle reviewed Feb 4, 2022

View reviewed changes

mauromalara requested a review from Rebits February 21, 2022 19:31

mauromalara added subteam/qa-hurricane and removed subteam/qa-earthquake labels Feb 21, 2022

mauromalara dismissed their stale review via b5e3cdf February 21, 2022 19:55

Rebits requested changes Mar 11, 2022

View reviewed changes

mauromalara force-pushed the 1850-check-queue-socket-status-test branch from 0411859 to c435418 Compare March 14, 2022 20:13

mauromalara requested a review from Rebits March 15, 2022 12:04

Rebits force-pushed the 1850-check-queue-socket-status-test branch 3 times, most recently from ee6960b to c435418 Compare March 16, 2022 10:54

Fernando and others added 17 commits March 17, 2022 10:37

add: Add new test_queue_socket_status first approach #1850

5d2c1cb

add: Added stopping and restarting analysisd daemon implementation #1850

d19996a

refac: Changed test name #1850

f3b7af7

add: Added new fixtures implementation #1850

edd0055

doc: Documented test_queue_socket_properties #1850

52bdeb0

add: Add documentation's requested changes #1850

4a46c77

add: Add new documentation's requested changes #1850

23955d5

doc: Add new requested documentation's changes #1850

e1f487f

fix: fix style with pep8 style guide #1850

79ce42e

refac: Some variables extracted from the QA framework. #1850

f0da290

doc: wazuh_min_version changed

c46a84f

doc: CHANGELOG.md updated. #1850

31d70d5

Fixtures rearrangement to test unmodified socket

3cf67fc

doc: parameter brief changed. #1850

5095133

doc: tag changed. #1850

effa132

doc: min version corrected. #1850

b464f14

Merge branch 'master' into 1850-check-queue-socket-status-test

71b156e

Rebits force-pushed the 1850-check-queue-socket-status-test branch from c435418 to 71b156e Compare March 17, 2022 10:50

fix: recover mauromalara last improvements in the framework and test_…

179fd42

…queue_socket_properties Co-authored-by: mauromalara <[email protected]>

Rebits approved these changes Mar 17, 2022

View reviewed changes

Rebits merged commit a38138b into master Mar 17, 2022

Rebits deleted the 1850-check-queue-socket-status-test branch March 17, 2022 17:22

damarisg mentioned this pull request Sep 28, 2022

Add a test to check the analysisd socket properties #3365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Analysisd - add new test to check analysisd socket properties #2405

Analysisd - add new test to check analysisd socket properties #2405

fernandolojano commented Dec 24, 2021 •

edited

Loading

mauromalara commented Dec 31, 2021

mauromalara left a comment •

edited

Loading

mauromalara commented Feb 3, 2022

jnasselle left a comment •

edited

Loading

mauromalara commented Feb 21, 2022

mauromalara commented Feb 21, 2022 •

edited

Loading

Rebits left a comment

mauromalara commented Mar 14, 2022 •

edited

Loading

Rebits commented Mar 16, 2022

Rebits left a comment

Analysisd - add new test to check analysisd socket properties #2405

Analysisd - add new test to check analysisd socket properties #2405

Conversation

fernandolojano commented Dec 24, 2021 • edited Loading

Description

Tests

mauromalara commented Dec 31, 2021

mauromalara left a comment • edited Loading

Choose a reason for hiding this comment

mauromalara commented Feb 3, 2022

03/02/2022

Package

Testing

Analysisd

jnasselle left a comment • edited Loading

Choose a reason for hiding this comment

mauromalara commented Feb 21, 2022

mauromalara commented Feb 21, 2022 • edited Loading

21/02/2022

Packages

Local

Jenkins

Testing

Rebits left a comment

Choose a reason for hiding this comment

mauromalara commented Mar 14, 2022 • edited Loading

14/03/2022

Package

Testing

Analysisd

Rebits commented Mar 16, 2022

16/03/2022

Package

Testing

test_analysisd

Rebits left a comment

Choose a reason for hiding this comment

fernandolojano commented Dec 24, 2021 •

edited

Loading

mauromalara left a comment •

edited

Loading

jnasselle left a comment •

edited

Loading

mauromalara commented Feb 21, 2022 •

edited

Loading

mauromalara commented Mar 14, 2022 •

edited

Loading

`test_analysisd`