System Test: Module (WAZUH-DB) - The agent with state different than never_connected is added to a "group_test" group by API #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Deblintrake09
suggested changes
Mar 11, 2022
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
damarisg
requested changes
Mar 14, 2022
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
Comment on lines
120
to
123
| response = host_manager.make_api_call('wazuh-master', method='PUT', | ||
| endpoint=f'/agents/{agent_id}/group/group_test?pretty=true', | ||
| token=token) | ||
| print(response) |
There was a problem hiding this comment.
Are there tests that use other methods like "PUT"? If this is the case, we could add method_name on a file with each one.
Comment on lines
120
to
123
| response = host_manager.make_api_call('wazuh-master', method='PUT', | ||
| endpoint=f'/agents/{agent_id}/group/group_test?pretty=true', | ||
| token=token) | ||
| print(response) |
There was a problem hiding this comment.
Suggested change
| response = host_manager.make_api_call('wazuh-master', method='PUT', | |
| endpoint=f'/agents/{agent_id}/group/group_test?pretty=true', | |
| token=token) | |
| print(response) | |
| response = host_manager.make_api_call('wazuh-master', method='PUT', | |
| endpoint=f'/agents/{agent_id}/group/group_test?pretty=true', | |
| token=token) |
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
damarisg
requested changes
Mar 14, 2022
tests/system/test_cluster/test_agent_groups/test_assign_agent_to_a_group_api.py
Outdated
Show resolved
Hide resolved
damarisg
requested changes
Mar 14, 2022
Comment on lines
129
to
130
| # Delete group of agent | ||
| delete_group_of_agents('wazuh-master', 'group_test', host_manager) |
There was a problem hiding this comment.
This section should always be executed whether it fails or not. Add this inside a finally section .
Deblintrake09
approved these changes
Mar 15, 2022
Tests Results
|
damarisg
requested changes
Mar 15, 2022
Comment on lines
+74
to
+90
| def test_assign_agent_to_a_group(agent_target, initial_status, clean_environment, test_infra_managers, test_infra_agents, | ||
| host_manager): | ||
| ''' | ||
| description: Check agent enrollment process and new group assignment works as expected in a cluster environment. | ||
| Check that when an agent pointing to a master/worker node is registered, and when | ||
| it's assigned to a new group using API the change is sync with the cluster. | ||
| wazuh_min_version: 4.4.0 | ||
| parameters: | ||
| - agent_target: | ||
| type: string | ||
| brief: name of the host where the agent will register | ||
| - initial_status: | ||
| type: string | ||
| brief: status of the agent when the assign the new group | ||
| - clean_enviroment: | ||
| type: fixture | ||
| brief: Reset the wazuh log files at the start of the test. Remove all registered agents from master. |
There was a problem hiding this comment.
There aren't the variables(test_infra_managers, test_infra_agents, host_manager) defined as parameters of the documentation.
damarisg
approved these changes
Mar 16, 2022
15 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the test suite for
The agent with state different than never_connected is added to a "group_test" group by APIis added. A total of new test cases covering different modes and combinations of options.Cases:
- The agent is active and registers with group to the
masternode using API- The agent is disconnected and registers with group to the
masternode using API- The agent is active and registers with group to the
workernode using API- The agent is disconnected and registers with group to the
workernode using APIConfiguration options
In order to run the test, first the environment located in
/test/system/provisioning/enrollment_clustermust be enabled with:sudo ansible-playbook -i inventory.yml playbook.yml --extra-vars='{"wazuh_branch": "dev-10771-agent-groups-files-to-wazuh-db"}'Local Internal Options: No Local Internal Options used
Tests Results
Required
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.