-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows System folders monitoring test support #3720
Conversation
5084fd6
to
f94979a
Compare
...ndows_system_folder_redirection/data/test_cases/cases_windows_system_folder_redirection.yaml
Outdated
Show resolved
Hide resolved
.../test_files/test_windows_system_folder_redirection/test_windows_system_folder_redirection.py
Outdated
Show resolved
Hide resolved
.../test_files/test_windows_system_folder_redirection/test_windows_system_folder_redirection.py
Show resolved
Hide resolved
.../test_files/test_windows_system_folder_redirection/test_windows_system_folder_redirection.py
Outdated
Show resolved
Hide resolved
.../test_files/test_windows_system_folder_redirection/test_windows_system_folder_redirection.py
Outdated
Show resolved
Hide resolved
# tests | ||
@pytest.mark.parametrize('test_folders', [test_folders], ids='', scope='module') | ||
@pytest.mark.parametrize('configuration, metadata', zip(configurations, configuration_metadata), ids=test_case_ids) | ||
def test_windows_folder_redirection(configuration, metadata, test_folders, set_wazuh_configuration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIM has a lot of tests, so I have a few suggestions:
1
. To organize the tests correctly, could you improve the path where is store the test? I see words that a lot are repeated.
It should be more general to help us separate by sections.
2
. I would like to know is what happens in this case of synchronization.
We have a section that is to add synchronization tests and contains other cases to check it. Why did you decide not to do synchronization cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Renamed the test name to avoid repeating words and be a bit more descriptive.
- This has not been tested for synchronization, because it is not related to it, no changes related to synchronization. It was needed to test that the folders are monitored and redirection from
Sysnative
works properly, but once it is monitored, the synchronization behavior is the same as any other folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
We will wait for another reviewer to review it. I think that it should be improved.
-
Resolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding 2, as talked in call, This fix does not affect synchronization at all, it is just a fix so Windows system folders can be properly monitored. Once monitored, the synchronization works as with any other folder.
Description
This PR aims to add IT support for FIM monitoring of windows' system folders (System32, SysWOW64) and path redirection from Sysnative to System32.
Added
test_windows_system_folder_redirection
test suite adds a total of 9 test cases, monitoring the different system folders in each fim_mode.Testing performed