Fix monitoring module for e2e tests

[Rebits]

Description

This PR include a fix for the monitoring module in E2E tests

Testing performed

Testing

In [36]: monitoring_data =         {
In [36]: monitoring_data =         {
    ...:            "manager1":[
    ...:               {
    ...:                  "regex": r'(\d{4}\/\d{2}\/\d{2} \d{2}:\d{2}:\d{2}) .*? INFO: Testi
    ...: ng2',
    ...:                  "file":"/tmp/testing",
    ...:                  "timeout":10,
    ...:                  "n_iterations":1,
    ...:                  "greater_than_timestamp":"2024-02-20T17:12:22.33"
    ...:               }
    ...:            ]
    ...:         }

In [37]: monitoring_events_multihost(hm, monitoring_data)
Out[37]: 
{'manager1': {'not_found': [{'regex': '(\\d{4}\\/\\d{2}\\/\\d{2} \\d{2}:\\d{2}:\\d{2}) .*? INFO: Testing2',
    'file': '/tmp/testing',
    'timeout': 10,
    'n_iterations': 1,
    'greater_than_timestamp': '2024-02-20T17:12:22.33'}],
  'found': []}}

In [38]: monitoring_data =         {
    ...:            "manager1":[
    ...:               {
    ...:                  "regex": r'(\d{4}\/\d{2}\/\d{2} \d{2}:\d{2}:\d{2}) .*? INFO: Testi
    ...: ng',
    ...:                  "file":"/tmp/testing",
    ...:                  "timeout":10,
    ...:                  "n_iterations":1,
    ...:                  "greater_than_timestamp":"2024-02-20T17:12:22.33"
    ...:               }
    ...:            ]
    ...:         }

In [39]: monitoring_events_multihost(hm, monitoring_data)
Out[39]: {'manager1': {'not_found': [], 'found': ['2024/02/21 10:33:37']}}

In [40]: monitoring_data =         {
    ...:            "manager1":[
    ...:               {
    ...:                  "regex": r'Testing',
    ...:                  "file":"/tmp/testing",
    ...:                  "timeout":10,
    ...:                  "n_iterations":1,
    ...:                  "greater_than_timestamp":"2024-02-20T17:12:22.33"
    ...:               }
    ...:            ]
    ...:         }

In [41]: 

In [41]: monitoring_events_multihost(hm, monitoring_data)
---------------------------------------------------------------------------
ValueError           

In [42]: monitoring_data =         {
    ...:            "manager1":[
    ...:               {
    ...:                  "regex": r'Testing',
    ...:                  "file":"/tmp/testing",
    ...:                  "timeout":10,
    ...:                  "n_iterations":1,
    ...: 
    ...:               }
    ...:            ]
    ...:         }

In [43]: monitoring_events_multihost(hm, monitoring_data)
Out[43]: {'manager1': {'not_found': [], 'found': ['Testing', 'Testing', 'Testing']}}


In [44]: monitoring_data =         {
    ...:            "manager1":[
    ...:               {
    ...:                  "regex": r'(\d{4}\/\d{2}\/\d{2} \d{2}:\d{2}:\d{2}) .*? INFO: Testi
    ...: ng',
    ...:                  "file":"/tmp/testing",
    ...:                  "timeout":10,
    ...:                  "n_iterations":1,
    ...:                  "greater_than_timestamp":"2024-03-20T17:12:22.33"
    ...:               }
    ...:            ]
    ...:         }

In [45]: monitoring_events_multihost(hm, monitoring_data)
Out[45]: 
{'manager1': {'not_found': [{'regex': '(\\d{4}\\/\\d{2}\\/\\d{2} \\d{2}:\\d{2}:\\d{2}) .*? INFO: Testing',
    'file': '/tmp/testing',
    'timeout': 10,
    'n_iterations': 1,
    'greater_than_timestamp': '2024-03-20T17:12:22.33'}],
  'found': []}}


             

[juliamagan]

GJ!

[juliamagan]

If you already have the greater_than_timestamp field, is it necessary to add the timestamp regex to the regex field? Isn't it a bit repetitive?

[Rebits]

To effectively compare with the time specified in the greater_than_timestamp parameters, we need to gather the timestamp from the event. Therefore, the specified regex should be designed to match at least one group, specifically tailored for capturing the timestamp.

[juliamagan]

We will revisit this in the future

[juliamagan]

LGTM