Fix timeout and performance issues in Indexer E2E requests #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliamagan
requested changes
Feb 22, 2024
deps/wazuh_testing/wazuh_testing/end_to_end/vulnerability_detector.py
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/end_to_end/vulnerability_detector.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Show resolved
Hide resolved
| @@ -139,6 +133,12 @@ def setup_vulnerability_tests(host_manager: HostManager) -> Generator: | |||
| logger.error("Restarting managers") | |||
| host_manager.control_environment('restart', ['manager']) | |||
|
|
|||
| logger.error("Save the Wazuh indexer username and password into the Wazuh manager keystore") | |||
There was a problem hiding this comment.
Shouldn't it be info or debug instead of error?
There was a problem hiding this comment.
We have not determinate the logic of the logging. I suggest the following:
- Critical: Logging messages from the tests
- Error: Logging messages from the fixtures
- Info: Logging messages from the rest of the libraries
- Debug: Very verbose logging messages like testinfra/ansible debug messages
There was a problem hiding this comment.
We will revisit this in the future
| logging_message = 'Syscollector scan not started in the following agents:' \ | ||
| f"{test_result['evidences']['agents_not_scanned_first_scan']}." | ||
| logger.critical(logging_message) | ||
| pytest.fail(logging_message) | ||
| else: | ||
| logger.critical("All agents has been scanned") |
There was a problem hiding this comment.
Related conversation #5003 (comment)
There was a problem hiding this comment.
We will revisit this in the future
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Show resolved
Hide resolved
Co-authored-by: Julia Magan <[email protected]>
Co-authored-by: Julia Magan <[email protected]>
Co-authored-by: Julia Magan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR include several fixes for the E2E Vulnerability Detection tests:
Testing performed
E2E Initial scans: InitialScans.zip
Warning
No assets were included due to they surpass the maximun size. We should consider allow customization of the report assets to reduce the size
Report failures are due to:
test_syscollector_first_scan_alerts: No vulns are detected for windows hosts. Reported here Vulnerability Detection encounters issues while processing PyPI packages wazuh#21811test_syscollector_first_scan_index: It seems that indexer connection was lost in the middle of the test. Further research is required. It has been checked manually that wazuh-indexer is running and the keystore was correctly updated. After restarting indexer seems to work as expected.tests_syscollector_vulnerabilities_index_alerts_consistency: Same as test_syscollector_first_scan_index