Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soliditySha3 docs #3908

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Update soliditySha3 docs #3908

merged 2 commits into from
Feb 10, 2021

Conversation

spacesailor24
Copy link
Contributor

Fixes #3907

@coveralls
Copy link

coveralls commented Feb 9, 2021

Pull Request Test Coverage Report for Build 552354768

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 226 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.5%) to 76.273%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 82.27%
packages/web3-utils/src/utils.js 27 10.74%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.92%
packages/web3-utils/src/index.js 42 32.12%
packages/web3-eth-accounts/src/index.js 85 33.06%
Totals Coverage Status
Change from base Build 538231133: 2.5%
Covered Lines: 3172
Relevant Lines: 3944

💛 - Coveralls

Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally something which should be fixed in terms of best practices. We should even think about deprecating it. I just tested it and the examples are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for soliditySha3 to include security risk warning
3 participants