Release/1.3.5 #3974

spacesailor24 · 2021-03-24T01:50:28Z

Added

Github action for running tests for web3-eth2-core and web3-eth2-beaconchain packages (Add eth2 github action #3892)
Added description to documentation on how to connect using a remote node provider (Remote node provider edits #3884)
Added Security risk warning to docs for web3.utils.soliditySha3 (Update soliditySha3 docs #3908)
.nvmrc file using Node.js version v.14.15.1 (add nvmrc file #3817)
Add commitment to semantic versioning since version 1.3.0 and onwards (Debugging failing test #3961)

Changed

Unified babel compiler for web3-eth2-core and web3-eth2-beaconchain (Add eth2 github action #3892)
Renamed the tsc script in all packages to compile; updates the corresponding lerna run usage in the main package.json (Update tsc npm command to compile #3894)
moved deprecation warnings to postinstall scripts (use posinstall to do deprecation warnings #3917)
Upgrade @chainsafe/geth-dev-assistant from 0.1.5 to 0.1.9 (Merging geth-dev-assistant updates #3950)
Replaced hardcoded infura link with Github Secret for some tests (Replace hardcoded infura endpoints #3943)
Bump elliptic from 6.5.3 to 6.5.4 for web3-eth-accounts (Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts #3941)
Bump elliptic from 6.5.3 to 6.5.4 for web3-bzz (Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz #3940)
Bump elliptic from 6.5.3 to 6.5.4 for web3-core-requestmanager (Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager #3945)
Rewrite web3-eth-iban in ES6 (Rewrite web3-eth-iban #3955)

render · 2021-03-24T01:50:31Z

Your Render PR Server URL is https://web3-js-pr-3974.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1d9lplua9vondbnpdc0.

spacesailor24 · 2021-03-24T01:59:14Z

Replicating the steps mentioned in previous releases

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

installs properly
builds
tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts	✔️
~~synthetix~~	~1000 units	❌
protocol	Uses (latest) web3.js heavily, and also uses other libs such as Uniswap's	❌

Synthetic tests failed with same JavaScript heap out of memory as last release, so I'm replacing it with the tests from UMAprotocol

Protocol tests failed with (using the latest 1.3.4 release and 1.3.5-rc.0):

@uma/financial-templates-lib:   606 passing (38m)
@uma/financial-templates-lib:   4 failing
@uma/financial-templates-lib:   1) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib:        Basic historical price:
@uma/financial-templates-lib:      Error: TraderMade-test-pair: time 1611626300 is before firstPriceTime.openTime
@uma/financial-templates-lib:       at TraderMadePriceFeed.getHistoricalPrice (src/price-feed/TraderMadePriceFeed.js:125:13)
@uma/financial-templates-lib:       at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:114:34)
@uma/financial-templates-lib:       at runMicrotasks (<anonymous>)
@uma/financial-templates-lib:       at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib:   2) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib:        apiKey present:
@uma/financial-templates-lib:       AssertionError: expected [ Array(3) ] to deeply equal [ Array(3) ]
@uma/financial-templates-lib:       + expected - actual
@uma/financial-templates-lib:        [
@uma/financial-templates-lib:       -  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-23-22:00&end_date=2021-02-25-22:43&format=records&interval=hourly"
@uma/financial-templates-lib:       -  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-25-22:30&end_date=2021-02-25-22:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib:       +  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-24-04:00&end_date=2021-02-26-04:43&format=records&interval=hourly"
@uma/financial-templates-lib:       +  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-26-04:30&end_date=2021-02-26-04:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib:          "https://marketdata.tradermade.com/api/v1/live?currency=test-pair&api_key=test-api-key"
@uma/financial-templates-lib:        ]
@uma/financial-templates-lib:       
@uma/financial-templates-lib:       at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:499:12)
@uma/financial-templates-lib:       at runMicrotasks (<anonymous>)
@uma/financial-templates-lib:       at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib:   3) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib:        apiKey absent:
@uma/financial-templates-lib:       AssertionError: expected [ Array(3) ] to deeply equal [ Array(3) ]
@uma/financial-templates-lib:       + expected - actual
@uma/financial-templates-lib:        [
@uma/financial-templates-lib:       -  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-23-22:00&end_date=2021-02-25-22:43&format=records&interval=hourly"
@uma/financial-templates-lib:       -  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-25-22:30&end_date=2021-02-25-22:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib:       +  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-24-04:00&end_date=2021-02-26-04:43&format=records&interval=hourly"
@uma/financial-templates-lib:       +  "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-26-04:30&end_date=2021-02-26-04:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib:          "https://marketdata.tradermade.com/api/v1/live?currency=test-pair&api_key=undefined"
@uma/financial-templates-lib:        ]
@uma/financial-templates-lib:       
@uma/financial-templates-lib:       at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:512:12)
@uma/financial-templates-lib:       at runMicrotasks (<anonymous>)
@uma/financial-templates-lib:       at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib:   4) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib:        Hourly interval can act as historical price fallback for minute interval
@uma/financial-templates-lib:          Fallback to hourly interval ENABLED, failure to fetch minute interval successfully fetches hourly data:
@uma/financial-templates-lib:      Error: TraderMade-test-pair: time 1611626300 is before firstPriceTime.openTime
@uma/financial-templates-lib:       at TraderMadePriceFeed.getHistoricalPrice (src/price-feed/TraderMadePriceFeed.js:125:13)
@uma/financial-templates-lib:       at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:239:36)
@uma/financial-templates-lib:       at runMicrotasks (<anonymous>)
@uma/financial-templates-lib:       at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib: error Command failed with exit code 4.
@uma/financial-templates-lib: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run test exited 4 in '@uma/financial-templates-lib'
error Command failed with exit code 4.

coveralls · 2021-03-24T02:05:51Z

Pull Request Test Coverage Report for Build 720258403

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.702%

Totals
Change from base Build 663272150:	0.0%
Covered Lines:	3277
Relevant Lines:	4208

💛 - Coveralls

frankiebee

YASSSSSS 🥳

* Release/1.3.5 (#3974) * Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <[email protected]> * Bump underscore (#4051) * bump underscore * update package-locks * bump lcoks again * Release 1.3.6 (#4053) * Update CHANGELOG and ran npm i * Built lib for 1.3.6-rc.0 * v1.3.6-rc.0 * npm i * Built lib for 1.3.6-rc.1 * v1.3.6-rc.1 * 1.3.6-rc.2 (#4059) * npm i && npm audit fix * Manually bump version to 1.3.6-rc.2 * Built lib for 1.3.6-rc.2 * v1.3.6-rc.2 * 1.3.6-rc.2 fixes (#4062) * Manually update dependency versions to 1.3.6-rc.2 * Accidental commit * npm i * Manually update web3 dependency version to 1.3.6-rc.2 * npm i * Built manually for 1.3.6-rc.2 * Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Gregory Markou <[email protected]> Co-authored-by: Gregory Markou <[email protected]> * Add web3-core-helpers as dev dependency * Add web3-core-helpers as dev dependency * Fixing 1.3.6-rc.2 related issues (#4063) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove dtslint from ci scripts (#4064) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove npm run dtslint from build and lint * 1.3.6-rc.2 Fixes (#4065) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove npm run dtslint from build and lint * Add back removed package: web3-eth-ens * npm i * Build lib * Add back npm run dtslint * Update geth-dev-assistant * v1.3.6 Co-authored-by: Gregory Markou <[email protected]> * Add unsubscribeByID (#4061) * adding function unsubscribe by id * adding an unsubscribe testcase * adding testcase * seperated unsubscribebyid to its own method * adding testcases * adding await * fixing testcases Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]> * ignore .md and docs (#4077) * adding berlin tx support (#4109) * add berlin tx support * update install locations * update package name in comment * fix existing tests to support new tx sigining format * remove build * remove old test case * use latest ethereumjs/tx * bump deps and fix test * update hashes * fix messageHash, decoding bug * fix tests * add hack * adding eip2930 and common object * fix lint updating package-lock * fix berlin tx signing and recovery * updating ethereumjs/tx package * updating checksum * removing helper.js * updating changelog and docs * fixing typo Co-authored-by: Gregory Markou <[email protected]> * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth (#4154) * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Fix typo * Release v1.4.0 (#4118) * npm run build for 1.4.0-rc.0 * v1.4.0-rc.0 * 1.4.0 Geth version downgrade (#4149) * Update pull Geth docker version from stable to pre-london (1.10.3) * Update CHANGELOG * v1.4.0 Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Gregory Markou <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Gregory Markou <[email protected]>

* Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <[email protected]>

* Release/1.3.5 (#3974) * Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <[email protected]> * Merge conflicts * Merge conflicts * Add unsubscribeByID (#4061) * adding function unsubscribe by id * adding an unsubscribe testcase * adding testcase * seperated unsubscribebyid to its own method * adding testcases * adding await * fixing testcases Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]> * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Update CHANGELOG (#4193) Test don't run when only changes to `CHANGELOG.md` have been made Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Gregory Markou <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]>

atifnimran · 2023-03-01T09:33:05Z

Ok

spacesailor24 added 3 commits March 23, 2021 20:40

Update changelog

a128561

Built dist

5a3701a

Update version numbers

a79835d

frankiebee changed the title ~~Release/1.3.5~~ Release/1.3.5-rc Mar 24, 2021

spacesailor24 changed the title ~~Release/1.3.5-rc~~ Release/1.3.5-rc.0 Mar 24, 2021

frankiebee changed the title ~~Release/1.3.5-rc.0~~ Release/1.3.5 Mar 24, 2021

frankiebee changed the title ~~Release/1.3.5~~ Release/1.3.5-rc.0 Mar 24, 2021

spacesailor24 requested review from frankiebee and koraykoska March 24, 2021 01:59

spacesailor24 added the Release label Mar 24, 2021

v1.3.5

6674ea5

spacesailor24 changed the title ~~Release/1.3.5-rc.0~~ Release/1.3.5 Apr 5, 2021

frankiebee approved these changes Apr 5, 2021

View reviewed changes

spacesailor24 merged commit 5d02719 into 1.x Apr 5, 2021

spacesailor24 added a commit that referenced this pull request Jul 27, 2021

Release/1.3.5 (#3974)

6843a11

* Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <[email protected]>

affiliatedkat mentioned this pull request Nov 27, 2023

[Snyk] Fix for 1 vulnerabilities affiliatedkat/web3.js#32

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/1.3.5 #3974

Release/1.3.5 #3974

spacesailor24 commented Mar 24, 2021

render bot commented Mar 24, 2021

spacesailor24 commented Mar 24, 2021 •

edited

Loading

coveralls commented Mar 24, 2021 •

edited

Loading

frankiebee left a comment

atifnimran commented Mar 1, 2023

Release/1.3.5 #3974

Release/1.3.5 #3974

Conversation

spacesailor24 commented Mar 24, 2021

Added

Changed

render bot commented Mar 24, 2021

spacesailor24 commented Mar 24, 2021 • edited Loading

coveralls commented Mar 24, 2021 • edited Loading

Pull Request Test Coverage Report for Build 720258403

💛 - Coveralls

frankiebee left a comment

Choose a reason for hiding this comment

atifnimran commented Mar 1, 2023

spacesailor24 commented Mar 24, 2021 •

edited

Loading

coveralls commented Mar 24, 2021 •

edited

Loading