-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(simulate|write)Contract payable value not working for overloads #2531
Labels
Comments
Yuripetusko
added a commit
to Yuripetusko/viem
that referenced
this issue
Jul 30, 2024
Yuripetusko
added a commit
to Yuripetusko/viem
that referenced
this issue
Jul 30, 2024
tmm
added a commit
that referenced
this issue
Aug 6, 2024
* fixes #2560 value type on function overload * Create new-hotels-sell.md * revert GetValue changes and create new GetMutabilityAwareValue type * remove un-used test * revert test abi * use mutability aware type util on writeContract too * fix: wrong import * lint * fix import * Update .changeset/new-hotels-sell.md --------- Co-authored-by: Tom Meagher <[email protected]>
This issue has been locked since it has been closed for more than 14 days. If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Check existing issues
Viem Version
2.17.11
Current Behavior
If an overloaded function has nonpayable and payable overloads,
simulateContract
andwriteContract
'svalue
parameter is not inferred correctly for the payable overload.Expected Behavior
Payable overload should allow
value
property.Steps To Reproduce
No response
Link to Minimal Reproducible Example
https://www.typescriptlang.org/play/?target=99#code/JYWwDg9gTgLgBAbzgYygUwIYzQdQwG3zRgGF9g0A7GAGjgAsYYw6wMoBnNAQQCNg4AXzgAzKBBBwA5ADcKIKXAD0SuDACeYNBwBccAEwA6AIwB2E8YBQoSLERwA7lGDYSEalAzJacDqACu+Fhobh5e8MJiEtJyaCBK4cDuHIoqapraekZmFtbg0PBIIBjAlJTEQqLikrLySsj0JZQpyqoaWroGJubGVpbIyfDI5FTwALwo6MF4hMRkFNQAFAiWcHBeA-7UelIADAAeUjSrKI2lesWl5bQnMJ7NtjB6jMyLAJTHgm-9g+v8cBM2JwePxFgBtE5SERbbxJSi+DAiNAAFXuHCRUAAYtVFhgACZ49AcDh0fGE7QkuD+UowfQAVgAbG8jpDoZRYe4EUjURhmhjsRJcQSiZSySK6NTqPSGXReOpsBw3nA2OoMLwiCyALrfSxOFwhdx3cKLYYLHwrNZiik7A4sy38Y5rNkcygAOQwIDQOw4iJRaP51Tt6ygAHNOmC9vtDNGjtIDtHDLHjLtdpRNY7WnAAAIwDgAWjQ+y03gLUHEUBOMgI-i9cGMlE+3z1rkNnm8JpG1DoFvWwutccOGbVwAzzpgcPdnu9vp5fLQWMDQ9D4cjCdjq5jdGTqboG8T6cr1dr9cblksfhAgWCoSN7dNo27JytxJtg6fDpOY4nHtrUh93P9ecBQUJcwz0CN403Ac1y3FM0wzNIc3zQtixgUty0PfAaz0E9LC+c8AiCFswjvTtzSfPsXwHINh1HGFx3cSdf3-P1eXRIDFyfZdwL3ddIMTWCd2gmMDzWKssOPBs8O+IA
Anything else?
No response
The text was updated successfully, but these errors were encountered: