Fix: #2531 value types function overload #2560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error
```
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/yuri/Sites/polkadot/viem/node_modules/is-plain-obj/index.js from /Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js not supported.
Instead change the require of /Users/yuri/Sites/polkadot/viem/node_modules/is-plain-obj/index.js in /Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js to a dynamic import() which is available in all CommonJS modules.
at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js:3:23)
at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/meow/index.js:3:28)
at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/dist/cli.cjs.dev.js:3:12)
at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/dist/cli.cjs.js:6:20)
at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/bin.js:4:1) {
code: 'ERR_REQUIRE_ESM'
}
```
This reverts commit 103f688.
…changeset" This reverts commit 591f0f7.
…e not commited" This reverts commit ae24aa8.
|
|
@Yuripetusko is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Yuripetusko
changed the title
Yuripetusko
added a commit
to Yuripetusko/viem
that referenced
this pull request
Jul 30, 2024
tmm
added a commit
that referenced
this pull request
Aug 6, 2024
* fixes #2560 value type on function overload * Create new-hotels-sell.md * revert GetValue changes and create new GetMutabilityAwareValue type * remove un-used test * revert test abi * use mutability aware type util on writeContract too * fix: wrong import * lint * fix import * Update .changeset/new-hotels-sell.md --------- Co-authored-by: Tom Meagher <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2531. Infer
valuetype for function overload where some of the functions are payable and others arent. Using args to find the matching function from overload union, then picking it's value typeP.S. Not sure why it shows so many commits. Probably needed to cut a new branch from upstream 🤔
PR-Codex overview
This PR introduces changes related to estimating contract fees and gas, adding a new function
mint, updating contract ABIs, and refining contract writing actions.Detailed summary
mintfunction withpayablestate to contract ABIsGetValuefunction signatures to includemutabilityandargsGetValuefunctionviempackage