feat(chip): add the chip component #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamraider
commented
Apr 18, 2019
adamraider
commented
adamraider
commented
Apr 18, 2019
| @@ -0,0 +1,68 @@ | |||
| class Chip { | |||
There was a problem hiding this comment.
This needs tests before we merge.
cmugla
reviewed
Apr 18, 2019
| } | ||
|
|
||
| _bindEventListeners() { | ||
| this._root.addEventListener('mousedown', this.onMousedown); |
There was a problem hiding this comment.
Thoughts on adding a touchstart event as well? Not sure what the best UX is for this - seeing on my phone that they don't work very well for quicker, slightly clumsier gestures
maniator
reviewed
May 30, 2019
|
Closing in favor of #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.