Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely parse color string #1079

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Safely parse color string #1079

merged 1 commit into from
Apr 23, 2024

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Apr 23, 2024

Fixes wordpress-mobile/WordPress-Android#20694 and wordpress-mobile/WordPress-Android#20698

Related PRs:

Fix

This PR adds exception handling for the Color.parseColor function call to prevent the app from crashing. Similar handling is done in two other case in Aztec (one, two)

Test

I was not able to reproduce the crash thus I suggest a sanity check of the functionality introduced in #1073

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@antonis antonis added bug Gutenberg This issue is also valid importing Aztec in Gutenberg labels Apr 23, 2024
@antonis antonis requested a review from geriux April 23, 2024 09:26
Copy link

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to reproduce by using:

<!-- wp:paragraph -->
<p><mark style="background-color:rgba(0,0,0,0);color:#000" class="has-inline-color has-black-color">Hey</mark></p>
<!-- /wp:paragraph -->

With these changes the crash is fixed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Gutenberg This issue is also valid importing Aztec in Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException: Unknown color
2 participants