-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes unknown color Aztec crash #20704
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Quality Gate passedIssues Measures |
Found 1 violations: The PR caused some dependency changes (expand to see details)
\--- project :libs:editor
- +--- org.wordpress:aztec:{strictly v2.1.1} -> v2.1.1
+ +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
- +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.1} -> v2.1.1
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.1 (*)
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.2 (*)
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.1} -> v2.1.1
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.1 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.2 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
\--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.117.0
\--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.117.0
- +--- org.wordpress:aztec:v2.1.1 (*)
+ +--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*)
- +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 -> v2.1.2 (*)
- +--- org.wordpress.aztec:wordpress-comments:v2.1.1 (*)
+ +--- org.wordpress.aztec:wordpress-comments:v2.1.1 -> v2.1.2 (*)
\--- org.wordpress.aztec:glide-loader:v2.1.1
- \--- org.wordpress:aztec:v2.1.1 (*)
+ \--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*)
Please review and act accordingly
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/24.7 #20704 +/- ##
=================================================
+ Coverage 40.46% 82.58% +42.12%
=================================================
Files 1484 15 -1469
Lines 68417 534 -67883
Branches 11308 50 -11258
=================================================
- Hits 27682 441 -27241
+ Misses 38233 75 -38158
+ Partials 2502 18 -2484 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've testing pasting the following content:
<mark style="background-color:rgba(0,0,0,0);color:#000" class="has-inline-color">Hey</mark>
And using a theme (Penscratch 2) that has a custom color with values like #000
Fixes #20694 and #20698
Depends on: wordpress-mobile/AztecEditor-Android#1079
Handles unknown color values in Aztec
To Test:
See wordpress-mobile/AztecEditor-Android#1079 (review)
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):