Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unknown color Aztec crash #20704

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fixes unknown color Aztec crash #20704

merged 2 commits into from
Apr 23, 2024

Conversation

antonis
Copy link

@antonis antonis commented Apr 23, 2024

Fixes #20694 and #20698

Depends on: wordpress-mobile/AztecEditor-Android#1079

Handles unknown color values in Aztec


To Test:

See wordpress-mobile/AztecEditor-Android#1079 (review)


Regression Notes

  1. Potential unintended areas of impact

    • Editor
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 23, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@antonis antonis requested a review from geriux April 23, 2024 15:11
@antonis antonis marked this pull request as ready for review April 23, 2024 15:13
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20704-aed78e7
Commitaed78e7
Direct Downloadjetpack-prototype-build-pr20704-aed78e7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20704-aed78e7
Commitaed78e7
Direct Downloadwordpress-prototype-build-pr20704-aed78e7.apk
Note: Google Login is not supported on these builds.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 \--- project :libs:editor
-     +--- org.wordpress:aztec:{strictly v2.1.1} -> v2.1.1
+     +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
-     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.1} -> v2.1.1
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.1 (*)
-     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.2 (*)
+     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
-     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.1} -> v2.1.1
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.1 (*)
-     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.2 (*)
+     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
      \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.117.0
           \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.117.0
-               +--- org.wordpress:aztec:v2.1.1 (*)
+               +--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*)
-               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 (*)
+               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 -> v2.1.2 (*)
-               +--- org.wordpress.aztec:wordpress-comments:v2.1.1 (*)
+               +--- org.wordpress.aztec:wordpress-comments:v2.1.1 -> v2.1.2 (*)
                \--- org.wordpress.aztec:glide-loader:v2.1.1
-                    \--- org.wordpress:aztec:v2.1.1 (*)
+                    \--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*)

Please review and act accordingly

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (936ab4a) to head (aed78e7).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/24.7   #20704       +/-   ##
=================================================
+ Coverage         40.46%   82.58%   +42.12%     
=================================================
  Files              1484       15     -1469     
  Lines             68417      534    -67883     
  Branches          11308       50    -11258     
=================================================
- Hits              27682      441    -27241     
+ Misses            38233       75    -38158     
+ Partials           2502       18     -2484     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonis antonis linked an issue Apr 23, 2024 that may be closed by this pull request
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've testing pasting the following content:

<mark style="background-color:rgba(0,0,0,0);color:#000" class="has-inline-color">Hey</mark>

And using a theme (Penscratch 2) that has a custom color with values like #000

@antonis antonis linked an issue Apr 23, 2024 that may be closed by this pull request
@antonis antonis merged commit 16d3ba2 into release/24.7 Apr 23, 2024
21 checks passed
@antonis antonis deleted the fix/20694-unknowncolor branch April 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException: Unknown color IllegalArgumentException: Unknown color
4 participants