Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Leia] Use the full BaseUrl if it's a real url inside an AdaptationSet #566

Closed

Conversation

michaelarnauts
Copy link
Contributor

Backport of #565

@michaelarnauts
Copy link
Contributor Author

@peak3d Since the matrix-change had just been merged, can you also merge this backport? Thanks a lot!

@peak3d
Copy link
Contributor

peak3d commented Dec 12, 2020

@michaelarnauts there are 2 more issues regarding url composing.
Let me figure them out, after that backport.....

@michaelarnauts
Copy link
Contributor Author

@peak3d any update? I have two broken add-ons so I would love to have a release before the holidays...

michaelarnauts added a commit to michaelarnauts/inputstream.adaptive that referenced this pull request Dec 18, 2020
michaelarnauts added a commit to michaelarnauts/inputstream.adaptive that referenced this pull request Dec 18, 2020
@michaelarnauts
Copy link
Contributor Author

Any progress? Something where I can help?

@MPParsley
Copy link

Hi @peak3d, any chance for a release with this?

@michaelarnauts
Copy link
Contributor Author

@phunkyfish I didn't know a Leia release was happening. This is a simple bugfix that could have also been released.

@michaelarnauts
Copy link
Contributor Author

O, never mind.it seems the commit made it into the release. Not sure how that happened 🙂

@phunkyfish
Copy link
Contributor

O, never mind.it seems the commit made it into the release. Not sure how that happened 🙂

@matthuisman added it 😉

@phunkyfish
Copy link
Contributor

phunkyfish commented Apr 10, 2021

@phunkyfish I didn't know a Leia release was happening. This is a simple bugfix that could have also been released.

That is the last Leia release

@matthuisman
Copy link
Contributor

Yes. Snuck it in! This PR could now be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants