Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Leia] Backport Matrix bug fixes #634

Merged
merged 9 commits into from
Apr 10, 2021
Merged

[Leia] Backport Matrix bug fixes #634

merged 9 commits into from
Apr 10, 2021

Conversation

matthuisman
Copy link
Contributor

@matthuisman matthuisman commented Apr 8, 2021

@matthuisman matthuisman changed the title [Matrix] Backport regression fixes (Draft) [Leia] Backport bug fixes Apr 8, 2021
@matthuisman matthuisman marked this pull request as ready for review April 8, 2021 23:14
@matthuisman
Copy link
Contributor Author

matthuisman commented Apr 8, 2021

@glennguy ready for review when your ready :)

@phunkyfish
I know you said just regressions, but I really feel the other PRs are pretty essential to get 18 stable and working with all current add-ons. It will be it's last update so may as well make it as good as possible? It will keep as many devs and users as happy as possible.

@matthuisman matthuisman changed the title [Leia] Backport bug fixes [Leia] Backport Matrix bug fixes Apr 8, 2021
@phunkyfish
Copy link
Contributor

phunkyfish commented Apr 9, 2021

Is this supposed to push to binary addon repos or not? Or just push there for manual install only?

If you want the push to the binary addon repos the jenkinsfile will need to be updated.

@glennguy
Copy link
Contributor

glennguy commented Apr 9, 2021

As mentioned on slack can you bring in #499 plus DllHelper.h and the one-line change in main.h?

@matthuisman
Copy link
Contributor Author

matthuisman commented Apr 10, 2021

did up a test repo:

  1. Start with stock Kodi 18.9
  2. Enable debug logging
  3. Install https://f.mjh.nz/test/plugin.video.rivedila7-Leia.zip (test add-on)
  4. Try to play "LA7 Live" - won't work
  5. Install repo: https://f.mjh.nz/test/repository.inputstream.adaptive.0.0.1.zip
  6. Update Inputstream Adaptive to 2.4.7 (will auto update if updates enabled)
  7. Try to play "LA7 Live" - still won't work as bug in 18 keeps using the built-in old .so
    If you skip step 4 - it will play as IA .so wouldn't have been loaded yet
  8. Restart Kodi
  9. Try to play "LA7 Live" - will work
  10. Confirm in log that IA correctly loads
    /data/user/0/org.xbmc.kodi/cache/lib/libinputstream.adaptive.so&
    /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/inputstream.adaptive/libssd_wv.so

Here is my log:
before restart: kodi.log.txt
after restart: kodi.log.txt

Not a big deal for needing a restart as IA will just keep using the old built-in libinputstream.adaptive.so & libssd_wv.so until its restarted.

Conclusion - this PR is ready to go!

@phunkyfish
Copy link
Contributor

Well we need to have Matrix/master working from repo first. Once that is working we can bring this in.

@glennguy what is needed on the matrix side?

@glennguy
Copy link
Contributor

I'll leave a comment in #601

Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants